Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirejs.yml changes not picked up when precompile_unchanged_assets is false #165

Closed
jonhyman opened this issue Aug 14, 2013 · 3 comments

Comments

@jonhyman
Copy link

commented Aug 14, 2013

We use requirejs-rails for requirejs support in the asset pipeline. We just ran into a problem where we made a modification to config/requirejs.yml but because the assets hadn't changed, they were not recompiled again and our staging environment was taken down until we fixed it.

I think you should add this file to files to check for differences with this setting.

@martinemde

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2013

We added the asset_dependencies setting in ey.yml for exactly this reason. This allows future compatibility with new asset plugins without requiring us to modify the source all the time.

ey.yml:

defaults:
  asset_dependencies: # a list of relative paths to search for asset changes during each deploy.
  # default
  - app/assets
  - lib/assets
  - vendor/assets
  - Gemfile.lock
  - config/application.rb
  - config/routes.rb
  # custom
  - config/requirejs.yml

You'll want to copy all the defaults into your ey.yml file and then add config/requirejs.yml. I included a good example for you above. Tweak as necessary.

I also updated the documentation in the README so this option is better explained.

@martinemde martinemde closed this Aug 14, 2013

@jonhyman

This comment has been minimized.

Copy link
Author

commented Aug 14, 2013

Oh great. I didn't realize. Thanks!

Sent from my mobile device
On Aug 14, 2013 6:27 PM, "Martin Emde" notifications@github.com wrote:

We added the asset_dependencies setting in ey.yml for exactly this
reason. This allows future compatibility with new asset plugins without
requiring us to modify the source all the time.

ey.yml:

defaults:
asset_dependencies: # a list of relative paths to search for asset changes during each deploy.

default

  • app/assets
  • lib/assets
  • vendor/assets
  • Gemfile.lock
  • config/application.rb
  • config/routes.rb

    custom

  • config/requirejs.yml

You'll want to copy all the defaults into your ey.yml file and then add
config/requirejs.yml. I included a good example for you above. Tweak as
necessary.

I also updated the documentation in the README so this option is better
explained.


Reply to this email directly or view it on GitHubhttps://github.com//issues/165#issuecomment-22672390
.

@martinemde

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2013

Whenever I get a ticket about something that exists, I wonder how I could have explained it better. It'd be best if people didn't have to file a ticket to learn about it.

I'm going to improve the default ey.yml written down by the CLI when you first deploy so it has this as an example. Thanks for getting me to check that out. The examples were out of date.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.