Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FB-1764] Support for Ruby with jemalloc #146

Merged
merged 4 commits into from Nov 18, 2019

Conversation

jfuechsl
Copy link
Contributor

Description of your patch

This PR adds support for Ruby with jemalloc. It can be enabled by setting the EY_RUBY_JEMALLOC environment variable.

Recommended Release Notes

Adds support for Ruby with jemalloc.

Estimated risk

High. Significant changes in the ruby recipes.

Components involved

ruby recipes

Dependencies

None

Description of testing done

Tested creating & booting & deploying an env with jemalloc enabled (for Ruby 2.5 and 2.6).
Tested enabling jemalloc on an existing environment.

QA Instructions

Test with different cluster configurations.
Test with different Ruby app servers.
Test a PHP app.

Copy link
Contributor

@DalianisDim DalianisDim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DalianisDim DalianisDim merged commit 6a97dde into next-release Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants