New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FBZ-10448] - Migrate New Relic Infra Recipe to v7 #109
Conversation
}) | ||
end | ||
|
||
execute "curl -s https://download.newrelic.com/infrastructure_agent/gpg/newrelic-infra.gpg | sudo apt-key add -" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keys should be added under apt_repository process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved key under apt_repository process
apt_repository "newrelic-infra" do
uri "https://download.newrelic.com/infrastructure_agent/linux/apt"
distribution "focal"
distribution "#{`lsb_release -cs`.strip}"
components ["main"]
key "https://download.newrelic.com/infrastructure_agent/gpg/newrelic-infra.gpg"
end.run_action(:add)
@@ -0,0 +1 @@ | |||
deb [arch=amd64] https://download.newrelic.com/infrastructure_agent/linux/apt focal main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be generated when adding also, the type should support arm64 as well as amd64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed files folder as newrelic-infra.list
should be generated upon execution of apt_repository
process
Moved key under apt_repository process for
And removed files folder as newrelic-infra.list should be generated upon execution of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me passes linting process
This will be merged for next release |
Description of your patch
Adds support for New Relic Infra by migrating recipe from v6 to v7
Recommended Release Notes
Added support for New Relic Infra
Estimated risk
Medium
Components involved
cookbooks/ey-newrelic_infra
custom-cookbooks/newrelic_infra
Description of testing done
cookbooks/ey-newrelic_infra
andcustom-cookbooks/newrelic_infra
QA Instructions
cookbooks/ey-newrelic_infra
andcustom-cookbooks/newrelic_infra