Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FBZ-10448] - Migrate New Relic Infra Recipe to v7 #109

Merged
merged 2 commits into from Sep 26, 2022

Conversation

kdotbautista
Copy link
Contributor

Description of your patch
Adds support for New Relic Infra by migrating recipe from v6 to v7

Recommended Release Notes
Added support for New Relic Infra

Estimated risk
Medium

Components involved
cookbooks/ey-newrelic_infra
custom-cookbooks/newrelic_infra

Description of testing done

  • Create a new environment with v7 as stack
  • Upload recipe for cookbooks/ey-newrelic_infra and custom-cookbooks/newrelic_infra
  • Verify through the chef logs that ey-newrelic_infra recipe has been executed
  • Verify if New Relic Package has been successfully installed

QA Instructions

  • Create a new environment with v7 as stack
  • Upload recipe for cookbooks/ey-newrelic_infra and custom-cookbooks/newrelic_infra
  • Verify through the chef logs that ey-newrelic_infra recipe has been executed
  • Verify if New Relic Package has been successfully installed

@kdotbautista kdotbautista self-assigned this Aug 31, 2022
})
end

execute "curl -s https://download.newrelic.com/infrastructure_agent/gpg/newrelic-infra.gpg | sudo apt-key add -" do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keys should be added under apt_repository process

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved key under apt_repository process

apt_repository "newrelic-infra" do
  uri "https://download.newrelic.com/infrastructure_agent/linux/apt"
  distribution "focal"
  distribution "#{`lsb_release -cs`.strip}"
  components ["main"]
  key "https://download.newrelic.com/infrastructure_agent/gpg/newrelic-infra.gpg"
end.run_action(:add)

@@ -0,0 +1 @@
deb [arch=amd64] https://download.newrelic.com/infrastructure_agent/linux/apt focal main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be generated when adding also, the type should support arm64 as well as amd64

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed files folder as newrelic-infra.list should be generated upon execution of apt_repository process

@kdotbautista
Copy link
Contributor Author

Moved key under apt_repository process for cookbooks/ey-newrelic_infra/recipes/default.rb

apt_repository "newrelic-infra" do
  uri "https://download.newrelic.com/infrastructure_agent/linux/apt"
  distribution "focal"
  distribution "#{`lsb_release -cs`.strip}"
  components ["main"]
  key "https://download.newrelic.com/infrastructure_agent/gpg/newrelic-infra.gpg"
end.run_action(:add)

And removed files folder as newrelic-infra.list should be generated upon execution of apt_repository process.

Copy link
Contributor

@mushyy mushyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me passes linting process

@mushyy
Copy link
Contributor

mushyy commented Sep 7, 2022

This will be merged for next release

@mushyy mushyy merged commit affaa96 into next-release Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants