[FBZ-10492] Fix Custom Cron for DB and Util instances

[kdotbautista]

Description of your patch

Fix Custom Cron for DB and Util instances

Recommended Release Notes

Fixed Custom Cron for DB and Util instances

Estimated risk

Low

Components involved

All clients that uses custom-cron recipe

Dependencies

• custom-cron

Description of testing done

• Spin up a v7 environment with App Master, DB Master and 2 Util instances named as test1 and test2
• Add custom-cron recipe with custom crons below:

default["custom_crons"] = [{name: "test1", time: "10 * * * *", command: "echo 'test1'", instance_name: "test1"},
                          {name: "db", time: "10 1 * * *", command: "echo 'testdb'", instance_name: "db"},
                          {name: "app_master", time: "10 1 * * *", command: "echo 'testapp_master'", instance_name: "app_master"},
                          {name: "util", time: "10 1 * * *", command: "echo 'testutil'", instance_name: "util"}]

• Apply custom recipe
• Check the instances if the cron jobs were created for the ff.
  • app_master cron job for the App Master
  • db cron job for the DB Master
  • test1 and util cron jobs for the Utility instance named as test1
  • util cron job for the Utility instance named as test2

QA Instructions

• Spin up a v7 environment with App Master, DB Master and 2 Util instances named as test1 and test2
• Add custom-cron recipe with custom crons below:

default["custom_crons"] = [{name: "test1", time: "10 * * * *", command: "echo 'test1'", instance_name: "test1"},
                          {name: "db", time: "10 1 * * *", command: "echo 'testdb'", instance_name: "db"},
                          {name: "app_master", time: "10 1 * * *", command: "echo 'testapp_master'", instance_name: "app_master"},
                          {name: "util", time: "10 1 * * *", command: "echo 'testutil'", instance_name: "util"}]

• Apply custom recipe
• Check the instances if the cron jobs were created for the ff.
  • app_master cron job for the App Master
  • db cron job for the DB Master
  • test1 and util cron jobs for the Utility instance named as test1
  • util cron job for the Utility instance named as test2

[rupikakapoor]

@kdotbautista we need to fix the format in custom-cron examples as well https://github.com/engineyard/ey-cookbooks-stable-v7/blob/fbz10492_custom_cron_not_working_on_db_and_util/custom-cookbooks/cron/cookbooks/custom-cron/attributes/default.rb#L4

[rupikakapoor]

except that I have tested that recipe works fine.

[mushyy]

LGTM