engine: add a memory hash engine #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zojw
reviewed
Nov 30, 2021
| } | ||
|
|
||
| pub async fn set<K: Into<Vec<u8>>, V: Into<Vec<u8>>>(&self, key: K, value: V) { | ||
| let key = key.into(); |
There was a problem hiding this comment.
is it a internalKey(with seqNo or some mvcc version) or user key?
if it's user key, maybe we need maintain self.size like size = size + new_value - old_value when set exist key-value pair twice :)
There was a problem hiding this comment.
Oh, I haven't considered MVCC at this moment. So user keys and internal keys are the same things for now.
zojw
previously approved these changes
Nov 30, 2021
src/engine/hash/src/lib.rs
Outdated
| async fn table() -> Result<()> { | ||
| let records = vec![(vec![1], vec![1]), (vec![2], vec![2])]; | ||
|
|
||
| let filename = "/tmp/hash"; |
There was a problem hiding this comment.
maybe better use env::temp_dir() for windows developer~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enough for abstractions, let's build our first engine now.
This PR only handles some memory data. We will offer the hash engine an
Envlater to persist its state.I also remove the API part to avoid confusion for now.