Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window resizing and fullscreen behavior broken and inconsistent across all platforms [u524] #1069

Closed
EnigmaBot opened this issue Aug 2, 2017 · 8 comments
Labels
Bug Issues that are non fatal and occur at run time or compile time. Confirmed The issue has been confirmed as existing by another user or contributor. Graphics Game visuals including render state, geometry pipeline, rasterization, and related assets. Platforms Win32, Xlib, Cocoa, SDL and other target platforms.

Comments

@EnigmaBot
Copy link

(Posted by time-killer-games on the ENIGMA forums)

It should, but it isn't...

@EnigmaBot
Copy link
Author

(Posted by time-killer-games on the ENIGMA forums)

@JoshDreamland any chance you could fix this one if i gave you one big virtual hug?

@JoshDreamland
Copy link
Member

I don't use Windows, so I'd basically have to eyeball it, which I'm happy to do if I have guinea pigs. Otherwise, you should ask Robert.

@EnigmaBot
Copy link
Author

(Posted by time-killer-games on the ENIGMA forums)

@RobertBColton when you're less busy, any chance you could take a look at this? thanks!

@RobertBColton
Copy link
Contributor

Use the function, not the global game settings. There's tons of game settings that haven't been implemented, I was going to rework that at some point.

@JoshDreamland
Copy link
Member

JoshDreamland commented Aug 20, 2017

Wow, why is the global game setting not just using the function? Is it taken into account while setting up the window?

@RobertBColton
Copy link
Contributor

RobertBColton commented Aug 20, 2017

Nevermind, there is no actual function, the setting does work but he's right that the maximize button is for some reason disabled. It's probably the window style that's being set.

Edit: Can confirm in GMS 1.4 that the setting should allow the maximized button.

Edit 2: The setting is really hard to find because we name it 3 different things including allowResize, isSizable, allowWindowResize, and we also have an unused variable resizable.

Anyway, isSizable does set the maximize box style too so I don't know why it does appear:

newlong |= WS_SIZEBOX | WS_MAXIMIZEBOX;

@fundies
Copy link
Contributor

fundies commented Dec 24, 2017

putting #1083 and #1084 as they are all related

@fundies fundies changed the title When window is set to be resizeable, the maximize button should be enabled. [u524] Window reszing and fullscreen behavior broken and incosistent across all platforms [u524] Dec 24, 2017
@fundies fundies added Platforms Win32, Xlib, Cocoa, SDL and other target platforms. Bug Issues that are non fatal and occur at run time or compile time. Graphics Game visuals including render state, geometry pipeline, rasterization, and related assets. Confirmed The issue has been confirmed as existing by another user or contributor. labels Dec 24, 2017
@RobertBColton RobertBColton changed the title Window reszing and fullscreen behavior broken and incosistent across all platforms [u524] Window resizing and fullscreen behavior broken and inconsistent across all platforms [u524] Dec 26, 2017
@RobertBColton
Copy link
Contributor

RobertBColton commented Feb 16, 2019

Closing in favor of #1549 which better describes in detail the issues mentioned here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues that are non fatal and occur at run time or compile time. Confirmed The issue has been confirmed as existing by another user or contributor. Graphics Game visuals including render state, geometry pipeline, rasterization, and related assets. Platforms Win32, Xlib, Cocoa, SDL and other target platforms.
Projects
None yet
Development

No branches or pull requests

4 participants