Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Correct extension About.ey files #1012
There are two changes here. First, "ID" is being changed to "Identifier" for extensions as it is for the major systems so there is consistency. Second, "Name" was intended to be the human readable field as it is used in the major systems, but due to a bug that I just fixed in the plugin (enigma-dev/lgmplugin@ccc750a) "Identifier" was being used instead. So this PR swaps the role of "Identifier" and "Name".
Once this is merged, everybody is going to need the new ENIGMA plugin. Read the topic for more information about this issue.
I can definitely get behind these changes, but are you certain nothing is using the ID field right now? Also, are we requiring that the "identifier" field is the same as the folder name? In that case, if nothing is using it, why not just get rid of it? It's just another weird artifact to maintain, that way.
My biggest concern is that this will break how LGM tells ENIGMA which extensions to use. As I said, if LGM is currently using the name of the folder to point ENIGMA to the correct extension, then we're fine, and I recommend deleting the
The only argument I can see for keeping the identifier field is that, right now, there's nothing explicitly preventing spaces in the names of the extensions, while the "identifier" property seems to implicitly require no spaces.
We should figure out what codegen hinges on that assumption, if any, and verify that it is using the folder name (rather than
Actually, both are currently being used. Name is used as the GUI label in LGM so that it's human readable, i.e. "Matrix Math" where spaces are allowed.
My post was all about making the two consistent:
I can not verify to you at this time if anything else is still using/expecting it to be
The creator of LateralGM put
Which of the two of you was correct? I am guessing you, since ENIGMA is your thing. Also, leaving
Sounds good, we are consistent now then, and just to be clear, the Wiki article you started has since been updated to better reflect this consistently: