Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis for OSX and Optimize #1160

merged 58 commits into from Jan 18, 2018


Copy link

commented Jan 17, 2018

There's actually no need to specify the operating system for every job, you only have to specify it as an override for the two jobs that are run on OSX. So I first reverted all that two-line nonsense back to a single line.

Second, I used the two-line syntax to actually install certain packages, i.e. Box2D, only for the jobs that require them. I've also wrote a slightly lengthier script to install only the needed depends for each compiler target. Finally, I've allowed OSX to fail using the syntax @fundies discovered in #1159, but fixed it to actually speed up the build.

OSX Allowed Failures

This has all improved the build time significantly.

Copy link

left a comment

pointless change. keep the build matrix consistent


This comment has been minimized.

Copy link
Member Author

commented Jan 17, 2018

@fundies wrong, it is consistent. You are talking about two separate things, the build matrix, and included jobs. In your changes you actually completely removed the build matrix and made them all included jobs, which you didn't need to do, that's not how it works. We are not having the build matrix more than a single line for each job.

Further, this is actually how I am going to speed up the Travis build. This is the way that you can install a package only for a specific job, i.e. install Box2D just for the Box2D extension test and none of the other jobs. If Travis would cooperate I'd be able to finish this and show you.

@RobertBColton RobertBColton dismissed fundies’s stale review Jan 17, 2018

i haven't had the chance to do what i'm about to do

@RobertBColton RobertBColton changed the title Fix Travis for OSX Builds Fix Travis for OSX and Optimize Jan 17, 2018
RobertBColton added 25 commits Jan 18, 2018
@JoshDreamland JoshDreamland merged commit a97cf6e into master Jan 18, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
fundies added a commit that referenced this pull request Jan 18, 2018
Revert to the Matrix format of specifying environments. Retrofit OSX. Do not wait for OSX tests to finish before marking the build green.

try to hook up
@RobertBColton RobertBColton deleted the OSXTravis branch Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.