New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Glew and Use Package Instead #1226

Merged
merged 18 commits into from May 13, 2018

Conversation

Projects
None yet
3 participants
@RobertBColton
Member

RobertBColton commented May 12, 2018

I have to open a new PR to recreate #1137 because I do not have write access to @fundies master anymore.

fundies and others added some commits Jan 10, 2018

Fix AppVeyor Blobs (#1146)
* Update appveyor.yml (repeats for 18 commits)
Fix game global regressions (#1147)
fix game global regressions
Write a .desktop entry when building on Linux (#1143)
Creates a .desktop entry when performing a release build on Linux. The desktop file specifies the `applications-games-symbolic` icon, which is a generic icon typically rendered as playing cards, joystick, or gamepad. The user can easily modify the entry to use a custom icon.
Patch Makefiles. (#1150)
We shouldn't be passing `-d` to the emake Makefile, and we should use the rwildcard trick for its file globbing, too.
OS X fixes (#1139)
Commit fixes to get basic builds working on OSX; add OSX builds to Travis.
@codecov

This comment has been minimized.

codecov bot commented May 12, 2018

Codecov Report

Merging #1226 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1226   +/-   ##
======================================
  Coverage    9.22%   9.22%           
======================================
  Files         152     152           
  Lines       16631   16631           
======================================
  Hits         1534    1534           
  Misses      15097   15097
Impacted Files Coverage Δ
...tem/SHELL/Bridges/xlib-OpenGL1/graphics_bridge.cpp 44.68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85d9b5f...a2be6c4. Read the comment docs.

@JoshDreamland

With caveat:

Submitting this will break some users' installation. You should warn everyone on the forum that you're about to do this.

@RobertBColton

This comment has been minimized.

Member

RobertBColton commented May 13, 2018

@RobertBColton RobertBColton merged commit eb7a682 into master May 13, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 85d9b5f...a2be6c4
Details
codecov/project 9.22% remains the same compared to 85d9b5f
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@RobertBColton RobertBColton deleted the fundies-master branch May 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment