Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
3D Shapes Drawing Test #1350
Before we can generify models and shape drawing with the new vertex and index buffer abstractions, we need a test to ensure that nothing breaks. This pull request adds such a test that will show us all 6 shape drawing functions transformed to show all 6 sides in 3D space. For the sake of testing, the test actually shows 8 transformations even if 2 of the sides shown are shown twice.
I can not guarantee that all of these functions are actually rendering correctly even on master right now, so some changes may be introduced later with these specific drawing functions. Eventually, we'll also need a 3D lighting test as well.
@@ Coverage Diff @@ ## master #1350 +/- ## ========================================= + Coverage 13.63% 15.2% +1.57% ========================================= Files 168 168 Lines 17434 17434 ========================================= + Hits 2377 2651 +274 + Misses 15057 14783 -274
referenced this pull request
Aug 6, 2018
@JoshDreamland you're welcome. Anyway, I am going to now merge this as-is so I can begin writing a new 3D models class. I did attempt this morning to do isometric projections of the shapes, but only discovered our transforms in GL1 are totally messed up so the Isometric projection only works in D3D9 right now. We have to look into the transform issues and clean up all of that like I wanted to do as a separate task. For now, this is the best way I can test 3D shapes consistently.
This was what I tried:
//d3d_transform_set_rotation_x(-45); //d3d_transform_add_rotation_y(-45); d3d_transform_set_rotation_axis(1, 1, 0, -45); d3d_transform_add_translation(45, 45, 0); d3d_draw_shape(0, 20, test_texture);
Anyway, going to merge this now, best to not conflate shapes with transforms and projection tests for now anyway.