Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFixed GL1, DX9, DX11 and NONE not compiling with surface_create #1353
Conversation
Thanks, TheExDeus added these overloads for GL3 but never added defaults to the header for GL1/DX9. It's a nice feature to be able to disable the depth buffer and such though, hence they should stay. Thank you very much for fixing this. |
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Aug 10, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #1353 +/- ##
======================================
Coverage 15.2% 15.2%
======================================
Files 168 168
Lines 17434 17434
======================================
Hits 2651 2651
Misses 14783 14783
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
HitCoder9768 commentedAug 9, 2018
Fixed GL1, DX9, DX11 and NONE not compiling with surface_create due to new parameters
Surface create on the newer renderers has
int surface_create(int width, int height, bool depthbuffer, bool stencilbuffer, bool writeonly)
However, with older renderers stencilbuffer and writeonly are not present. Quick workaround allows games to be compiled as normal using these renderers.
The following line is now present in the 4 listed renderer's surface cpp files, adding the two bool parameters.
int surface_create(int width, int height, bool depthbuffer, bool, bool)