Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed GL1, DX9, DX11 and NONE not compiling with surface_create #1353

Merged
merged 2 commits into from Aug 10, 2018

Conversation

@HitCoder9768
Copy link
Contributor

HitCoder9768 commented Aug 9, 2018

Fixed GL1, DX9, DX11 and NONE not compiling with surface_create due to new parameters

Surface create on the newer renderers has
int surface_create(int width, int height, bool depthbuffer, bool stencilbuffer, bool writeonly)
However, with older renderers stencilbuffer and writeonly are not present. Quick workaround allows games to be compiled as normal using these renderers.

The following line is now present in the 4 listed renderer's surface cpp files, adding the two bool parameters.
int surface_create(int width, int height, bool depthbuffer, bool, bool)

HitCoder9768 added 2 commits Aug 9, 2018
…e to new parameters being introduced
@enigma-dev enigma-dev deleted a comment from RemoveRusky Aug 9, 2018
Copy link
Member

RobertBColton left a comment

Thanks, TheExDeus added these overloads for GL3 but never added defaults to the header for GL1/DX9. It's a nice feature to be able to disable the depth buffer and such though, hence they should stay. Thank you very much for fixing this.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 10, 2018

Codecov Report

Merging #1353 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1353   +/-   ##
======================================
  Coverage    15.2%   15.2%           
======================================
  Files         168     168           
  Lines       17434   17434           
======================================
  Hits         2651    2651           
  Misses      14783   14783
Impacted Files Coverage Δ
...ystem/SHELL/Graphics_Systems/OpenGL1/GLsurface.cpp 0.43% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42b7d98...fac88fd. Read the comment docs.

@RobertBColton RobertBColton merged commit e1e3e0a into enigma-dev:master Aug 10, 2018
3 of 4 checks passed
3 of 4 checks passed
codecov/patch 0% of diff hit (target 15.2%)
Details
codecov/project 15.2% remains the same compared to 42b7d98
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.