Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Perspective Projection Matrix #1528

Merged
merged 2 commits into from Feb 3, 2019

Conversation

Projects
None yet
2 participants
@RobertBColton
Copy link
Member

RobertBColton commented Feb 3, 2019

Josh helped me work through the issues with d3d_set_projection_perspective so that Project Mario's start screen works again. The issue is that its view matrix should have just been the rotation and translation, and the same is true for d3d_set_projection_ortho which we discovered via an apitrace.

With this change, Project Mario's start screen now draws correctly in the OpenGL systems. The Direct3D systems don't render correctly yet because of render state issues (I think z write enable is off, which I'll fix in a separate pull request). I also tested the fix in #1513 to make sure it is still working and saw no regression.

Project Mario Perspective Logo
Project Mario Perspective Start Screen

@RobertBColton RobertBColton requested a review from JoshDreamland Feb 3, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 3, 2019

Codecov Report

Merging #1528 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1528   +/-   ##
=======================================
  Coverage   17.56%   17.56%           
=======================================
  Files         165      165           
  Lines       17121    17121           
=======================================
  Hits         3008     3008           
  Misses      14113    14113
Impacted Files Coverage Δ
...system/SHELL/Graphics_Systems/General/GSmatrix.cpp 14.09% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36de74c...c947b57. Read the comment docs.

@RobertBColton RobertBColton force-pushed the perspective-projection-fix branch from 4e3f55b to c947b57 Feb 3, 2019

@RobertBColton RobertBColton merged commit ce622a5 into master Feb 3, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@RobertBColton RobertBColton deleted the perspective-projection-fix branch Feb 3, 2019

@RobertBColton

This comment has been minimized.

Copy link
Member Author

RobertBColton commented Feb 3, 2019

I can also mention that this is the first time we've had an even remotely compatible version of this function in ENIGMA. The version originally added by polygonz in 883f63f before I joined was totally fubar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.