Image Format Extensions & libpng #1548
Now that we have finished most of the new backend and stuff, I decided it's a great time to finish the switch from LodePNG to libpng. This is the cleanest, fastest, and most complete of my attempts compared to #1442 which had a lot of duplicate code. The primary motivation for using libpng is because it is generally available in package managers, unlike LodePNG, and it also happens to be faster according to my benchmarks performed in #1391 where libpng was requested.
It's important to mention I wasted a lot of time on the
Instead of updating the MinGW deps zip for fundies's jobs, I decided to add support for image format extensions instead. I was unable to get a libpng that would cooperate with the outdated MinGW on Ubuntu Trusty, which motivated me to do this. Anyway, that's why the libpng stuff here is being submitted as an extension that is enabled by default, but which the user can also disable at whim. This opens the door to users adding additional image format extensions if they so choose.
@@ Coverage Diff @@ ## master #1548 +/- ## ========================================= + Coverage 17.56% 17.6% +0.04% ========================================= Files 165 166 +1 Lines 17129 17134 +5 ========================================= + Hits 3008 3016 +8 + Misses 14121 14118 -3
6 times, most recently
Feb 15, 2019
Ye son, I'm trying to get it green so when Josh gets here tonight we can get the review finally done. I had it green just before I went to run errands but I backtracked a little bit to double check some things while I have time.
Edit: Ok, I think this is the last of my force pushes, definitely don't need the