Fix Flipped for libpng Extension Saving #1728
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran onto this while working on #1725 and hugar also mentioned it to me and on the forums at the same time. The libpng extension was not respecting the flipped parameter when saving. The reason is because we were flipping both the source read and destination write indices, where one obviously undoes the other. We only need to flip one of the indexes, not both. The one we should flip is the destination write index, since it is bounded by height, where the source read index is bounded by fullheight.