Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin FreeBSD Support #1916

Open
wants to merge 345 commits into
base: master
from

Conversation

@time-killer-games
Copy link
Contributor

time-killer-games commented Mar 11, 2020

Waiting for Josh to finish some stuff with JDI, in the meantime, you can make games for FreeBSD using this branch; I also finally got audio working but it requires building with clang instead of gcc. :D

jC26vln

Install instructions: https://enigma-dev.org/docs/Wiki/Install:FreeBSD

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #1916 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1916      +/-   ##
==========================================
+ Coverage   28.23%   28.23%   +<.01%     
==========================================
  Files         166      167       +1     
  Lines       17010    17013       +3     
==========================================
+ Hits         4803     4804       +1     
- Misses      12207    12209       +2
Impacted Files Coverage Δ
...ystem/SHELL/Platforms/xlib/Linux/LINUXjoystick.cpp 11.47% <ø> (ø)
ENIGMAsystem/SHELL/Platforms/xlib/XLIBmain.cpp 37.03% <ø> (ø) ⬆️
...stem/Extensions/DataStructures/data_structures.cpp 50.51% <0%> (-0.11%) ⬇️
...ELL/Platforms/General/POSIX/Linux/LINUXprogdir.cpp 100% <100%> (ø)
...NIGMAsystem/SHELL/Platforms/General/POSIX/main.cpp 92.3% <100%> (-1.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a999501...04bbb19. Read the comment docs.

CommandLine/emake/Makefile Outdated Show resolved Hide resolved
CommandLine/libEGM/Makefile Outdated Show resolved Hide resolved
CommandLine/libEGM/Makefile Outdated Show resolved Hide resolved
CommandLine/libEGM/Makefile Outdated Show resolved Hide resolved
ENIGMAsystem/SHELL/Audio_Systems/OpenAL/Makefile Outdated Show resolved Hide resolved
ENIGMAsystem/SHELL/Platforms/xlib/Linux/progdir.cpp Outdated Show resolved Hide resolved
shared/libpng-util/Makefile Outdated Show resolved Hide resolved
shared/protos/Makefile Outdated Show resolved Hide resolved
shared/protos/Makefile Outdated Show resolved Hide resolved
ENIGMAsystem/SHELL/Makefile Outdated Show resolved Hide resolved
ENIGMAsystem/SHELL/Makefile Show resolved Hide resolved
ENIGMAsystem/SHELL/Platforms/General/PFfilemanip.h Outdated Show resolved Hide resolved
ENIGMAsystem/SHELL/Platforms/None/Makefile Outdated Show resolved Hide resolved
shared/libpng-util/Makefile Outdated Show resolved Hide resolved
time-killer-games and others added 22 commits Mar 20, 2020
Copy link
Member

JoshDreamland left a comment

Treating BSD as if it were an entirely separate operating system is probably not the right move, unless it's really going to be a sticky hodgepodge of cherry-picks from Linux and Mac. I suspect it's mostly just Linux, since none of our Mac stuff works at all. Apart from the make→gmake switch, what actually changes between the Linux compilers and the FreeBSD versions?

return int(enigma_user::random(x));
}
template<class RandomIt>
void mt_random_shuffle(RandomIt first, RandomIt last) {

This comment has been minimized.

Copy link
@fundies

fundies Mar 26, 2020

Contributor

I see no need for this to be a template and is overall bad change because it generates a new seed every time you call it

This comment has been minimized.

Copy link
@time-killer-games

time-killer-games Mar 31, 2020

Author Contributor

i see no need for you to be a contributor to this project and is overall a bad change because you scared away every contributor we've ever had, other than me and Robert, due to your outrageous behavior. :P

@time-killer-games time-killer-games requested a review from JoshDreamland Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.