New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPI: -- spi_flash: fix bitbang with spi_width=1 #14

Merged
merged 1 commit into from Jan 17, 2017

Conversation

Projects
None yet
4 participants
@mithro
Collaborator

mithro commented Dec 26, 2016

Importing sb0's fix into litex.

@cr1901

https://github.com/mithro/litex/blob/e39c470bbc627212f394f528a0b1943b83cc7809/litex/soc/cores/flash/spi_flash.py#L114

If spi_width is 1, we will be sending data back on mosi instead of miso.

spi_width == 1 should be treated as a special case, since different lines are used for tx and rx.

@enjoy-digital

This comment has been minimized.

Show comment
Hide comment
@enjoy-digital

enjoy-digital Dec 27, 2016

Owner

@mithro , @cr1901 : is it working or is there a problem?

Owner

enjoy-digital commented Dec 27, 2016

@mithro , @cr1901 : is it working or is there a problem?

@mithro mithro changed the title from spi_flash: fix bitbang with spi_width=1 to WPI: -- spi_flash: fix bitbang with spi_width=1 Dec 27, 2016

@mithro

This comment has been minimized.

Show comment
Hide comment
@mithro

mithro Dec 27, 2016

Collaborator

@enjoy-digital - @cr1901 is working on this and will update the pull request once it is working properly.

Collaborator

mithro commented Dec 27, 2016

@enjoy-digital - @cr1901 is working on this and will update the pull request once it is working properly.

@enjoy-digital enjoy-digital merged commit 6d0096a into enjoy-digital:master Jan 17, 2017

@enjoy-digital

This comment has been minimized.

Show comment
Hide comment
@enjoy-digital

enjoy-digital Jan 17, 2017

Owner

Merged, I'll test and fix myself if needed.

Owner

enjoy-digital commented Jan 17, 2017

Merged, I'll test and fix myself if needed.

@mithro mithro deleted the mithro:spiflash2 branch Jan 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment