This repository was archived by the owner on Nov 29, 2023. It is now read-only.
Repository navigation
Fix: ensure dynamic manifest URLs are mapped - #360
Merged
eyelidlessness merged 3 commits intoNov 4, 2021
Merged
Conversation
lognaturel
reviewed
Nov 4, 2021
| } ); | ||
|
|
||
|
|
||
| it( 'escapes media URLs in markdown linkes', async () => { |
lognaturel
approved these changes
Nov 4, 2021
6 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes enketo/enketo#1036
I have verified this PR works with
[ ] None of the aboveWhat else has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
This is a slightly safer (escaping reserved HTML/XML entities, still handles spaces and other URL characters that need to be escaped) version of the previous solution, before #291 and was determined to be the lowest risk short-term solution. Other solutions considered:
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Do we need any specific form for testing your changes? If so, please attach one.
Any form with binary defaults (currently only for annotation fields, see enketo/enketo#1033).