Skip to content
This repository was archived by the owner on Nov 29, 2023. It is now read-only.

Switch from Travis CI to GitHub Actions CI - #379

Merged
eyelidlessness merged 1 commit into
enketo:masterfrom
eyelidlessness:chore/github-actions
Jan 31, 2022
Merged

Switch from Travis CI to GitHub Actions CI#379
eyelidlessness merged 1 commit into
enketo:masterfrom
eyelidlessness:chore/github-actions

Conversation

@eyelidlessness

Copy link
Copy Markdown
Contributor

Prerequisite of enketo/enketo#1030.

I have verified this PR works with

  • Online form submission
  • Offline form submission
  • Saving offline drafts
  • Submitting offline drafts
  • Editing submissions
  • Form preview
  • None of the above

What else has been done to verify that this works as intended?

It passes in CI (on my fork, as it won't run here until merged).

Why is this the best possible solution? Were any other approaches considered?

It's consistent with the same change we've made on other Enketo projects, and will help enable Codecov reporting.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

No user-facing code has changed. It's possible that there is some difference in CI behavior, but it does not appear to be the case.

Do we need any specific form for testing your changes? If so, please attach one.

N/A

@eyelidlessness eyelidlessness mentioned this pull request Jan 18, 2022
7 tasks

@lognaturel lognaturel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

sigh. Some weird state stuff with GitHub led me to think I hadn’t approved. So I guess I super approve!

@eyelidlessness
eyelidlessness merged commit 7d44187 into enketo:master Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants