Skip to content

Loading…

Add combustion development dependency. #5

Merged
merged 1 commit into from

2 participants

@ltw

Specs weren't running without combustion declared as a development dependency.

@jasoncodes
Ennova member

Should the .gemspec have the same version requirement as Appraisals?

@ltw

What's Appraisals?

@jasoncodes
Ennova member

Appraisal is a tool to test a library against different dependency versions. Postmarkdown’s tests run on Rails 3.0, 3.1 and 3.2.

@ltw

I must admit, I'm not sure what you're getting at here. I see no version requirement in this .gemspec for either appraisal or combustion, and I don't see any combustion dependency declaration in appraisal's .gemspec. What exactly are you looking for?

@jasoncodes
Ennova member

The Appraisals file in Postmarkdown's repository.

@ltw

Ah ok, fixed.

@jasoncodes
Ennova member

Sweet. Looks good.

@jasoncodes jasoncodes merged commit 57d530e into ennova:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 25, 2012
  1. Add combustion development dependency.

    Lucas Willett committed
Showing with 1 addition and 0 deletions.
  1. +1 −0 postmarkdown.gemspec
View
1 postmarkdown.gemspec
@@ -33,4 +33,5 @@ Gem::Specification.new do |s|
s.add_development_dependency 'capybara', '~> 1.0.0.beta'
s.add_development_dependency 'sqlite3'
s.add_development_dependency 'delorean', '>= 0.2'
+ s.add_development_dependency 'combustion', '~> 0.3.1'
end
Something went wrong with that request. Please try again.