Add combustion development dependency. #5

Merged
merged 1 commit into from Nov 25, 2012

Conversation

Projects
None yet
2 participants
@ltw

ltw commented Nov 18, 2012

Specs weren't running without combustion declared as a development dependency.

@jasoncodes

This comment has been minimized.

Show comment
Hide comment
@jasoncodes

jasoncodes Nov 21, 2012

Member

Should the .gemspec have the same version requirement as Appraisals?

Member

jasoncodes commented Nov 21, 2012

Should the .gemspec have the same version requirement as Appraisals?

@ltw

This comment has been minimized.

Show comment
Hide comment
@ltw

ltw Nov 21, 2012

What's Appraisals?

ltw commented Nov 21, 2012

What's Appraisals?

@jasoncodes

This comment has been minimized.

Show comment
Hide comment
@jasoncodes

jasoncodes Nov 21, 2012

Member

Appraisal is a tool to test a library against different dependency versions. Postmarkdown’s tests run on Rails 3.0, 3.1 and 3.2.

Member

jasoncodes commented Nov 21, 2012

Appraisal is a tool to test a library against different dependency versions. Postmarkdown’s tests run on Rails 3.0, 3.1 and 3.2.

@ltw

This comment has been minimized.

Show comment
Hide comment
@ltw

ltw Nov 23, 2012

I must admit, I'm not sure what you're getting at here. I see no version requirement in this .gemspec for either appraisal or combustion, and I don't see any combustion dependency declaration in appraisal's .gemspec. What exactly are you looking for?

ltw commented Nov 23, 2012

I must admit, I'm not sure what you're getting at here. I see no version requirement in this .gemspec for either appraisal or combustion, and I don't see any combustion dependency declaration in appraisal's .gemspec. What exactly are you looking for?

@jasoncodes

This comment has been minimized.

Show comment
Hide comment
@jasoncodes

jasoncodes Nov 23, 2012

Member

The Appraisals file in Postmarkdown's repository.

Member

jasoncodes commented Nov 23, 2012

The Appraisals file in Postmarkdown's repository.

@ltw

This comment has been minimized.

Show comment
Hide comment
@ltw

ltw Nov 25, 2012

Ah ok, fixed.

ltw commented Nov 25, 2012

Ah ok, fixed.

@jasoncodes

This comment has been minimized.

Show comment
Hide comment
@jasoncodes

jasoncodes Nov 25, 2012

Member

Sweet. Looks good.

Member

jasoncodes commented Nov 25, 2012

Sweet. Looks good.

jasoncodes added a commit that referenced this pull request Nov 25, 2012

Merge pull request #5 from ltw/add-combustion
Add combustion development dependency.

@jasoncodes jasoncodes merged commit 57d530e into ennova:master Nov 25, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment