Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console errors for browser locales unknown to CKEditor #552

Closed
ashklianko opened this issue Jun 19, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@ashklianko
Copy link
Member

commented Jun 19, 2019

Based on https://discuss.enonic.com/t/ckeditor-missing-locale-in-content-stuido/1912:

  1. Switch browser locale to Ukrainian and reopen browser
  2. Open any content with html area instance in

Result: HtmlArea instances are not fully loaded, errors in dev tools console present complaining regarding lang pack not found:

http://localhost:8080/admin/tool/com.enonic.app.contentstudio/main/_/asset/com.enonic.app.contentstudio:1560949524/lib/ckeditor/plugins/image2/lang/uk.js?t=IA8F net::ERR_ABORTED 404 (Not Found)

@ashklianko ashklianko self-assigned this Jun 19, 2019

@ashklianko ashklianko added the Bug label Jun 19, 2019

@alansemenov alansemenov changed the title CKEditor locale issue: errors in console Console errors for browser locales unknown to CKEditor Jun 21, 2019

@alansemenov

This comment has been minimized.

Copy link
Member

commented Jun 21, 2019

Let's add all CKE locale files matching languages that we support in admin UI (f.ex. for Norwegian add no, nb and nn). For all others fall back to english locale.

ashklianko added a commit that referenced this issue Jun 21, 2019

Console errors for browser locales unknown to CKEditor #552
-ckeditor had language config set to more languages than we had lang files in our cke build

1. Updated cke lang config to only those locales we support
2. Added Bokmål 'nb' locale
3. Cleaned non needed lang files in plugins

alansemenov added a commit that referenced this issue Jun 21, 2019

Merge pull request #571 from enonic/issue-552
Console errors for browser locales unknown to CKEditor #552

alansemenov added a commit that referenced this issue Jun 21, 2019

Console errors for browser locales unknown to CKEditor #552
-ckeditor had language config set to more languages than we had lang files in our cke build

1. Updated cke lang config to only those locales we support
2. Added Bokmål 'nb' locale
3. Cleaned non needed lang files in plugins

(cherry picked from commit 8dc8094)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.