Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console errors for browser locales unknown to CKEditor #552

Closed
ashklianko opened this issue Jun 19, 2019 · 1 comment
Closed

Console errors for browser locales unknown to CKEditor #552

ashklianko opened this issue Jun 19, 2019 · 1 comment
Assignees
@ashklianko
Labels
Bug Something isn't working
Milestone
2.0.2

Comments

@ashklianko
Copy link
Member

ashklianko commented Jun 19, 2019 •
edited

Based on https://discuss.enonic.com/t/ckeditor-missing-locale-in-content-stuido/1912:

  1. Switch browser locale to Ukrainian and reopen browser
  2. Open any content with html area instance in

Result: HtmlArea instances are not fully loaded, errors in dev tools console present complaining regarding lang pack not found:

http://localhost:8080/admin/tool/com.enonic.app.contentstudio/main/_/asset/com.enonic.app.contentstudio:1560949524/lib/ckeditor/plugins/image2/lang/uk.js?t=IA8F net::ERR_ABORTED 404 (Not Found)
@ashklianko ashklianko self-assigned this Jun 19, 2019
@ashklianko ashklianko added the Bug Something isn't working label Jun 19, 2019
@alansemenov alansemenov changed the title CKEditor locale issue: errors in console Console errors for browser locales unknown to CKEditor Jun 21, 2019
@alansemenov
Copy link
Member

Let's add all CKE locale files matching languages that we support in admin UI (f.ex. for Norwegian add no, nb and nn). For all others fall back to english locale.

ashklianko added a commit that referenced this issue Jun 21, 2019
@ashklianko
Console errors for browser locales unknown to CKEditor #552
8dc8094 
-ckeditor had language config set to more languages than we had lang files in our cke build

1. Updated cke lang config to only those locales we support
2. Added Bokmål 'nb' locale
3. Cleaned non needed lang files in plugins
alansemenov added a commit that referenced this issue Jun 21, 2019
@alansemenov
Merge pull request #571 from enonic/issue-552
0d21c50 
Console errors for browser locales unknown to CKEditor #552
alansemenov pushed a commit that referenced this issue Jun 21, 2019
@ashklianko @alansemenov
Console errors for browser locales unknown to CKEditor #552
be6895a 
-ckeditor had language config set to more languages than we had lang files in our cke build

1. Updated cke lang config to only those locales we support
2. Added Bokmål 'nb' locale
3. Cleaned non needed lang files in plugins

(cherry picked from commit 8dc8094)
@alansemenov alansemenov mentioned this issue Aug 6, 2019
Closed
@alansemenov alansemenov added this to the 2.0.2 milestone Aug 8, 2019
@alansemenov alansemenov mentioned this issue Sep 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashklianko ashklianko

Labels
Bug Something isn't working
Projects
None yet
Milestone
2.0.2
Development

No branches or pull requests
2 participants
@ashklianko @alansemenov