Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Sort, and HTML digest. #3
Quite a few changes.
First, fixed a bug where the
Second, fixed the sorting. While there was technically nothing wrong with sorting by the number of occurrences, it created some weird behavior in most cases, for example:
Since all the events are 1, it basically creates a radom sort. I fixed the problem by first sorting by the event date then by occurrences. I've also added a
Last, I've added an HTML template for the digest, which can be turned on using the
I think it could be turned on by default since both the plain text and HTML template are used in the email digest, but I did not want to change the current behavior.
@enricotagliavini Let me know if you have any questions/comments/suggestions.
sorry I fat fingered the keyboard and closed the pull request by accident, I'm reopening it now.
All good suggestions. Thank you for not changing the default behavior, I appreciate that, but I understand different sorting and HTML alternative is desirable. I just tried in gmail and it indeed looks not aligned correctly as they don't use a fixed width fonts.
I'll try it on my system this evening and it's probably good to be merged. I also commented on one line in one of the commits, let me know what you think about it.
Thank you very much for the contribution.