Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multicoin support for ENS #15

Merged
merged 3 commits into from Oct 12, 2019

Conversation

@Arachnid
Copy link
Member

Arachnid commented Sep 25, 2019

Arachnid added 2 commits Sep 24, 2019
@Arachnid Arachnid requested review from decanus and makoto Sep 25, 2019

mapping(bytes32=>address) addresses;
mapping(bytes32=>mapping(uint=>bytes)) _addresses;

This comment has been minimized.

Copy link
@decanus

decanus Sep 25, 2019

Member

Why is ETH 60?

This comment has been minimized.

Copy link
@Amxx

This comment has been minimized.

Copy link
@decanus

decanus Sep 25, 2019

Member

@Amxx perfect thanks

return bytesToAddress(a);
}

function setAddr(bytes32 node, uint coinType, bytes memory a) public authorised(node) {

This comment has been minimized.

Copy link
@decanus

decanus Sep 25, 2019

Member

Would it make sense to have some form of Code Repository with codes to strings?

This comment has been minimized.

Copy link
@Arachnid

Arachnid Oct 12, 2019

Author Member

Definitely - but offchain.

@Arachnid Arachnid merged commit 6214e52 into master Oct 12, 2019
4 checks passed
4 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Arachnid Arachnid deleted the multicoin branch Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.