SWANKY (over WebSockets) #1189

Closed
fommil opened this Issue Dec 20, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@fommil
Contributor

fommil commented Dec 20, 2015

can't believe we didn't have a ticket for this.

@fommil fommil added this to the Stable 1.0 milestone Dec 20, 2015

@fommil fommil referenced this issue in ensime/ensime-emacs Dec 20, 2015

Open

use SWANKY #316

@fommil fommil changed the title from SWANKY (SWANK over TCP and WebSockets) to SWANKY (over TCP and WebSockets) Dec 20, 2015

@fommil

This comment has been minimized.

Show comment
Hide comment
@fommil

fommil Dec 20, 2015

Contributor

oh, we did have this: #834 but that is also a more general refactor of the actual protocol itself too.

Contributor

fommil commented Dec 20, 2015

oh, we did have this: #834 but that is also a more general refactor of the actual protocol itself too.

@fommil fommil modified the milestones: Stable 1.0, TNG 2.0 Feb 15, 2016

@fommil fommil changed the title from SWANKY (over TCP and WebSockets) to SWANKY (over WebSockets) Mar 13, 2016

@fommil

This comment has been minimized.

Show comment
Hide comment
@fommil

fommil Mar 31, 2016

Contributor

this will involve deprecating the FamilyFormats and creating a spray-json-shapless style thing for s-express. Then well gradually migrate Emacs to SWANKY and Sublime to JERKY.

Contributor

fommil commented Mar 31, 2016

this will involve deprecating the FamilyFormats and creating a spray-json-shapless style thing for s-express. Then well gradually migrate Emacs to SWANKY and Sublime to JERKY.

@fommil

This comment has been minimized.

Show comment
Hide comment
@fommil

fommil Jul 9, 2016

Contributor

I've started working on this in https://github.com/fommil/ensime-server/tree/swanky

I debated in my head how general this should be: support for nils and alists and so on, and I decided just to go for the principle of least power and support only a minimal set of features for SexpData style formats (not alists). If we decide that alists are definitely preferable on the client side and worth breaking the .ensime format for, then we can reassess.

Contributor

fommil commented Jul 9, 2016

I've started working on this in https://github.com/fommil/ensime-server/tree/swanky

I debated in my head how general this should be: support for nils and alists and so on, and I decided just to go for the principle of least power and support only a minimal set of features for SexpData style formats (not alists). If we decide that alists are definitely preferable on the client side and worth breaking the .ensime format for, then we can reassess.

@fommil fommil referenced this issue Jul 9, 2016

Merged

SWANKY #1554

@aemoncannon

This comment has been minimized.

Show comment
Hide comment
@aemoncannon

aemoncannon Jul 10, 2016

Member

lgtm so far! I'm indifferent about alists.

Member

aemoncannon commented Jul 10, 2016

lgtm so far! I'm indifferent about alists.

@fommil fommil closed this in #1554 Jul 10, 2016

@fommil fommil removed the In progress label Jul 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment