Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sponsored] Analyzer per Project #1807

Merged
merged 14 commits into from Jun 22, 2017

Conversation

@VC1995
Copy link
Contributor

commented Jun 20, 2017

Extended BasicWorkflow to show that symbol tables are not shared between presentation compilers.

@VC1995

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2017

I wonder why I sometimes fail "should shutdown if preferred TCP port is not available" on Windows.
Also the added tests work as long as the sbt-ensime fix doesn't come in. Then the test configuration will automatically load the symbols of "compile" configuration we will no longer get the scala notes saying "not found: value Bloo"

@fommil fommil changed the title Analyzer per project: Extended BasicWorkflow [Sponsored] Analyzer per Project Jun 21, 2017

@fommil

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2017

@VC1995 please upgrade sbt-ensime and we'll see how it does

@fommil

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2017

of course, I can do it too 😄 let's see how that does

@VC1995

This comment has been minimized.

Copy link
Contributor Author

commented Jun 22, 2017

@fommil As expected : expected class org.ensime.api.NewScalaNotesEvent, found class org.ensime.api.FullTypeCheckCompleteEvent

@VC1995

This comment has been minimized.

Copy link
Contributor Author

commented Jun 22, 2017

I am guessing now the "test" configuration is depending on "compile". So we find the Blue class definition in the "compile" configuration and don't get the NewScalaNotesEvent as we earlier expected.
Should I modify the BasicWorkflow according to what we expect now ? :-)

@VC1995 VC1995 force-pushed the VC1995:analyzer-per-project branch from 0b36b42 to c44f7e4 Jun 22, 2017

@fommil

fommil approved these changes Jun 22, 2017

@fommil fommil merged commit 53b80ab into ensime:2.0 Jun 22, 2017

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@fommil fommil deleted the VC1995:analyzer-per-project branch Jun 22, 2017

@fommil fommil added this to Completed in Sponsorship Jul 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.