Skip to content
This repository has been archived by the owner. It is now read-only.

Updating README #42

Merged
merged 1 commit into from Jul 13, 2015
Merged

Updating README #42

merged 1 commit into from Jul 13, 2015

Conversation

@adilakhter
Copy link
Contributor

adilakhter commented Jul 9, 2015

  • Added a remark regarding installing coreutils (if missing) for mac users.
  • Added sublime configuration for external_server_port_file, required for the configuration of the sublime-ensime plugin.
  • Few minor formattings.
@rorygraves
Copy link
Contributor

rorygraves commented Jul 9, 2015

Hi @adilakhter,

Thanks for the PR - a couple of comments"

  1. I believe that "external_server_port_file": "$PROJECT/.ensime_cache/port" is no longer needed - I t should detected the port file based on the sublime project.
  2. Can you squash your commits?

Thanks

Rory

Updated code formatting.

- formatting start server section

fixing formatting

removed external_server_port_file as it is not required
@adilakhter adilakhter force-pushed the adilakhter:master branch from 6d2624b to 4f31e2a Jul 10, 2015
@adilakhter
Copy link
Contributor Author

adilakhter commented Jul 10, 2015

Hi Rory,

I have updated the pull request as you have suggested.

Thanks, Adil

@rorygraves
Copy link
Contributor

rorygraves commented Jul 13, 2015

Darn it, apologies for the delay - in my head I had merged it, in reality I had left it unmerged all weekend. D'oh.

Thanks for the PR!

rorygraves added a commit that referenced this pull request Jul 13, 2015
@rorygraves rorygraves merged commit bbaf04a into ensime:master Jul 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.