Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Pending requests dependent on loaded classes need to stick around #252
I believe this is also an issue for the way that pending requests are handled in the debugger api since we removed a pending breakpoint request as soon as it is successfully created once. Investigation, integration test proving issue, and fix are needed for this one.
Since pending requests are handled on startup and whenever a class prepare event is received, it seems even more likely that we could hit this case.
My assumption is that this would involve processing active breakpoints again along with pending each time a new class is loaded. In other words, modifying this method: https://github.com/ensime/scala-debugger/blob/master/scala-debugger-api/src/main/scala/org/scaladebugger/api/virtualmachines/StandardScalaVirtualMachine.scala#L188
I'll have to review the code again, but the idea would be to get a list of active breakpoints that are also associated with that file. From there, we just need to make certain that we don't duplicate requests for classes that have already. This means that we might need to
Could be a good way to learn a bit about the low level API and the profile system since it will touch both.