Change full-screen visualisation shortcut to shift-space #6663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Procrat
force-pushed
the
wip/procrat/shift-space-for-fullscreen-viz-6260
branch
from
e01c449
to
fae1b87
Compare
Procrat
requested review from
MichaelMauderer,
wdanilo,
farmaazon and
kazcw
as code owners
kazcw
approved these changes
May 12, 2023
farmaazon
approved these changes
May 12, 2023
…z-6260 * develop: Build nightlies every day. (#6681) Force `newDashboard` default on the CI-built packages. (#6680) Verify ascribed types of parameters really exist (#6584) SuggestionBuilder needs to send ascribedType of constructor parameters (#6655) Improvements to the Table visualization. (#6653) Removing flush (#6670) Improving widgets for take/drop (#6641)
…z-6260 * develop: Add verbose logs mention to CONTRIBUTING.md (#6703) Hide "shared with" column on local backend (#6684) Fix top bar styles (#6695) Fix opening cloud projects (#6683) Show spinner when opening/creating a project (#6321) Fix logic for enabling dashboard (#6696) Create unique atom getter suggestions (#6694) Ensure slow shutdown of LS always kicks off hooks (#6665) Fix `--startup.project` to bypass opening dashboard (#6671)
QA Report: 🔴I was unable to close the visualization with escape. It wasn't technically requested by the issue (only in the review), but I think it will be a great UX enhancement (otherwise user could have no clue how to exit FS visualization). |
|
E-Hern Lee reports a new STANDUP for yesterday (2023-05-16): Progress: address reviews; fixes for other PRs; address various other issues It should be finished by 2023-05-19. |
@farmaazon: I just tried it out again and it seems to work fine for me. What OS are you using? Do any of other |
|
Huh, after pulling changes (merge?) I'm also able to hide visualization with escape, so QA 🍏 |
|
whoops, wrong PR number |
Procrat
added a commit
that referenced
this pull request
May 22, 2023
…t-rename * develop: Widgets, Vector as Column, Viz Fixes and Rename Columns (#6768) Implement simple variants of `parse` for the Database backend (#6731) Enable `require-jsdoc` lint and add two lints related to React (#6403) Decimal/Integer .round and .int #6654 (#6743) Set suggestion reexports when serializing the library (#6778) Fix file uploading node expression. (#6689) Using WarningsLibrary to query for warnings (#6751) Implement `cast` for Table and Column (#6711) Display Initializing project... message when initializing project (#6661) Only send suggestions updates when type changes (#6755) sbt runEngineDistribution --debug to ease debuggging (#6745) Display "modified at" column on the cloud dashboard (#6687) Meta.meta Integer . methods (#6740) Show spinner while loading directory (#6714) Add cloud dashboard to changelog (#6688) Fix list editor panics during insertion (#6540) Update bug-report.yml Remove project create form (#6710) Change full-screen visualisation shortcut to shift-space (#6663)
Procrat
added a commit
that referenced
this pull request
May 22, 2023
* develop: (30 commits) Widgets, Vector as Column, Viz Fixes and Rename Columns (#6768) Implement simple variants of `parse` for the Database backend (#6731) Enable `require-jsdoc` lint and add two lints related to React (#6403) Decimal/Integer .round and .int #6654 (#6743) Set suggestion reexports when serializing the library (#6778) Fix file uploading node expression. (#6689) Using WarningsLibrary to query for warnings (#6751) Implement `cast` for Table and Column (#6711) Display Initializing project... message when initializing project (#6661) Only send suggestions updates when type changes (#6755) sbt runEngineDistribution --debug to ease debuggging (#6745) Display "modified at" column on the cloud dashboard (#6687) Meta.meta Integer . methods (#6740) Show spinner while loading directory (#6714) Add cloud dashboard to changelog (#6688) Fix list editor panics during insertion (#6540) Update bug-report.yml Remove project create form (#6710) Change full-screen visualisation shortcut to shift-space (#6663) Revert "Show spinner when opening/creating a project (#6321)" (#6712) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #6260: The shortcut to open the full-screen visualisation is now
shift-spaceso it doesn't interfere with thespaceshortcut to toggle the mini-visualisation.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Unit tests have been written where possible../run ide build.