New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 support #54

Merged
merged 20 commits into from Oct 1, 2015

Conversation

Projects
None yet
3 participants
@prabhuramachandran
Member

prabhuramachandran commented Aug 20, 2015

This fixes most of the tests on apptools with Python3. The io.h5 package has a bunch of issues but the others pass. These changes are needed for Mayavi. The changes cherry pick commits from Pradyun's PR here: #18.

pradyunsg and others added some commits May 12, 2014

Switch to `provides` from `implements`.
This is from Pradyun's python3 branch.
Several Python3 fixes.
`apptools.persistence.spickle` will not work on Python3 but the rest
seem to work and Mayavi also works well with these changes.
BUG: Handle case of tuple with references.
The StateTuple is a tuple so does not support __setitem__, this is
needed to handle numpy array references or other references.  We now
handle these with care so as to allow it to work correctly.

@prabhuramachandran prabhuramachandran referenced this pull request Sep 8, 2015

Merged

Python3 support #250

@prabhuramachandran

This comment has been minimized.

Show comment
Hide comment
@prabhuramachandran

prabhuramachandran Oct 1, 2015

Member

This is now RTM. All tests pass on 2.6, 2.7 and 3.4. Failures are no longer allowed on Python-3.4.

Member

prabhuramachandran commented Oct 1, 2015

This is now RTM. All tests pass on 2.6, 2.7 and 3.4. Failures are no longer allowed on Python-3.4.

@@ -19,10 +19,10 @@
import pickle
import struct
from pickle import Pickler, Unpickler, dumps, BUILD, NEWOBJ, REDUCE, \
MARK, OBJ, INST, BUILD, TupleType, PicklingError, GLOBAL, \
MARK, OBJ, INST, BUILD, PicklingError, GLOBAL, \
EXT1, EXT2, EXT4, _extension_registry, _keep_alive

This comment has been minimized.

@rkern

rkern Oct 1, 2015

Member

Since this module doesn't work on Python 3, I would recommend checking for Python 3 explicitly and raising an ImportError with a message that explains this.

@rkern

rkern Oct 1, 2015

Member

Since this module doesn't work on Python 3, I would recommend checking for Python 3 explicitly and raising an ImportError with a message that explains this.

This comment has been minimized.

@prabhuramachandran
@prabhuramachandran
@rkern

This comment has been minimized.

Show comment
Hide comment
@rkern

rkern Oct 1, 2015

Member

Great! If you can update CHANGES.txt with the good news and open a new issue about porting spickle to Python 3 (or deprecating it for all Python versions), I think that LGTM.

Member

rkern commented Oct 1, 2015

Great! If you can update CHANGES.txt with the good news and open a new issue about porting spickle to Python 3 (or deprecating it for all Python versions), I think that LGTM.

@prabhuramachandran

This comment has been minimized.

Show comment
Hide comment
@prabhuramachandran

prabhuramachandran Oct 1, 2015

Member

All done now. Created issue #57 as per your request.

Member

prabhuramachandran commented Oct 1, 2015

All done now. Created issue #57 as per your request.

@rkern

This comment has been minimized.

Show comment
Hide comment
@rkern

rkern Oct 1, 2015

Member

LGTM!

Member

rkern commented Oct 1, 2015

LGTM!

rkern added a commit that referenced this pull request Oct 1, 2015

@rkern rkern merged commit c5b1a75 into master Oct 1, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@rkern rkern deleted the feature/python3 branch Oct 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment