Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug during barplot creation... #102

Merged
merged 2 commits into from Mar 26, 2013
Merged

Conversation

@jonathanrocher
Copy link
Collaborator

jonathanrocher commented Feb 26, 2013

...that overwrite the low_ and high_settings. Moved the bounds computations into bounds_func attributes of the 2 DataRange1d. Added a couple of lines of comments.

…ed the bounds computations into the bounds_func attribute of the DataRange1d. Added a couple of lines of comments.
@rkern

This comment has been minimized.

Copy link
Member

rkern commented on chaco/plot.py in 09082de Feb 27, 2013

There is no need to explain old code in comments.

""" Compute custom bounds of the plot along index (in
data space).
"""
bar_width = styles.get('bar_width', cls().bar_width)

This comment has been minimized.

Copy link
@rkern

rkern Mar 20, 2013

Member

styles might override the bar_width.

This comment has been minimized.

Copy link
@jonathanrocher

jonathanrocher Mar 22, 2013

Author Collaborator

Robert, not sure I understand what you are suggesting here. Are you suggesting that we overwrite plot.bar_width with the value from the styles dict? That is done above in line 380 at the creation of the plot instance. Sorry I don't follow you.

This comment has been minimized.

Copy link
@rkern

rkern Mar 22, 2013

Member

Oh, I'm sorry, I completely misread that line. Please ignore. LGTM.

@rkern

This comment has been minimized.

Copy link
Member

rkern commented Mar 20, 2013

Comments aside, LGTM.

@jonathanrocher

This comment has been minimized.

Copy link
Collaborator Author

jonathanrocher commented Mar 26, 2013

Since it looks good to @rkern , I am merging this PR.

jonathanrocher pushed a commit that referenced this pull request Mar 26, 2013
Fix a bug during barplot creation that prevented for the ranges to update when the data updates.
@jonathanrocher jonathanrocher merged commit 5dfbf34 into master Mar 26, 2013
@jonathanrocher jonathanrocher deleted the barplot_settings_fix branch Mar 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.