Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the remote editor plugin. #137

Merged
merged 1 commit into from Feb 12, 2019

Conversation

mdickinson
Copy link
Member

@mdickinson mdickinson commented Feb 11, 2019

The remote editor plugin has been unmaintained for many years, and is untested and apparently unused.

This PR removes it.

I won't merge immediately; I want to give this a few days to check with other people about the history. If there are no objections, I'll merge in a few days' time.

Closes #134

@codecov-io
Copy link

codecov-io commented Feb 11, 2019

Codecov Report

Merging #137 into master will increase coverage by 0.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #137      +/-   ##
=========================================
+ Coverage   38.93%   39.4%   +0.47%     
=========================================
  Files         171     155      -16     
  Lines        5293    4575     -718     
  Branches      610     516      -94     
=========================================
- Hits         2061    1803     -258     
+ Misses       3164    2733     -431     
+ Partials       68      39      -29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 035b18c...8ca9e64. Read the comment docs.

@rahulporuri
Copy link
Contributor

LGTM.

@mdickinson
Copy link
Member Author

I want to give this a few days to check with other people about the history.

Done. Merging.

@mdickinson mdickinson merged commit d424afd into master Feb 12, 2019
@mdickinson mdickinson deleted the cleanup/remove-remote-editor-plugin branch February 12, 2019 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants