Passing the single coordinates to the method instead of the tuple. #23

Merged
merged 3 commits into from Feb 25, 2012

Conversation

Projects
None yet
2 participants
@mattions
Contributor

mattions commented Feb 8, 2012

mouse_dispatcher calls a generated method, which has two signature: V.pick(float, float, float, Renderer) -> int, and V.pick((float, float, float), Renderer) -> int.

In my system, the second one is never used. Instead the first one is used and an error is thrown, due to the wrong number of args. Therefore, passing the single coordinates fixes the problem.

Passing the single coordinates to the method instead of the tuple.
mouse_dispatcher calls a generated method, which has two signature: V.pick(float, float, float, Renderer) -> int, and V.pick((float, float, float), Renderer) -> int.

In my system, the second one is never used. Instead the first one is used and an error is thrown, due to the wrong number of args. Therefore, passing the single coordinates fixes the problem.
@mattions

This comment has been minimized.

Show comment
Hide comment
@mattions

mattions Feb 8, 2012

Contributor

This fix #21

Contributor

mattions commented Feb 8, 2012

This fix #21

@mattions

This comment has been minimized.

Show comment
Hide comment
@mattions

mattions Feb 8, 2012

Contributor

hey,
I've done it as suggested.

If you merge #21 is gone!

Contributor

mattions commented Feb 8, 2012

hey,
I've done it as suggested.

If you merge #21 is gone!

@GaelVaroquaux

This comment has been minimized.

Show comment
Hide comment
@GaelVaroquaux

GaelVaroquaux Feb 25, 2012

Collaborator

Thanks, Michele, I am merging this right now. There will be a new release of Mayavi next week, and your fix will be in it.

Collaborator

GaelVaroquaux commented Feb 25, 2012

Thanks, Michele, I am merging this right now. There will be a new release of Mayavi next week, and your fix will be in it.

GaelVaroquaux added a commit that referenced this pull request Feb 25, 2012

Merge pull request #23 from mattions/fix-21
Passing the single coordinates to the method instead of the tuple.

@GaelVaroquaux GaelVaroquaux merged commit 1d64e1c into enthought:master Feb 25, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment