Fix mlab.move error #306

Merged
merged 4 commits into from Mar 9, 2016

Conversation

Projects
None yet
3 participants
@kitchoi
Member

kitchoi commented Mar 2, 2016

Fix #292
camera.view_plane_normal is a tuple and so it needs to be converted to an array before being multiplied to -1

@dmsurti, @prabhuramachandran where should I put the tests for this? NullEngine can't be used because a scene is required. integrationtests/mayavi/test_mlab_* or create a test_camera.py under mayavi/tests ?

@prabhuramachandran

This comment has been minimized.

Show comment
Hide comment
@prabhuramachandran

prabhuramachandran Mar 2, 2016

Member

I think an integration test would work best as you need a UI. Thanks.

Member

prabhuramachandran commented Mar 2, 2016

I think an integration test would work best as you need a UI. Thanks.

@kitchoi

This comment has been minimized.

Show comment
Hide comment
@kitchoi

kitchoi Mar 4, 2016

Member

@prabhuramachandran I have added tests to integratedtests
The failed test on AppVeyor does not seem to be related to this PR and has occurred intermittently in the past.

Member

kitchoi commented Mar 4, 2016

@prabhuramachandran I have added tests to integratedtests
The failed test on AppVeyor does not seem to be related to this PR and has occurred intermittently in the past.

@prabhuramachandran

This comment has been minimized.

Show comment
Hide comment
@prabhuramachandran

prabhuramachandran Mar 9, 2016

Member

Thanks LGTM.

Member

prabhuramachandran commented Mar 9, 2016

Thanks LGTM.

prabhuramachandran added a commit that referenced this pull request Mar 9, 2016

@prabhuramachandran prabhuramachandran merged commit 70b66a5 into master Mar 9, 2016

3 of 5 checks passed

codecov/project CI failed: coverage not measured fully.
Details
continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@prabhuramachandran prabhuramachandran deleted the fix-issue-292 branch Mar 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment