Use newer pipeline where possible #309

Merged
merged 2 commits into from Mar 9, 2016

Conversation

Projects
None yet
3 participants
@prabhuramachandran
Member

prabhuramachandran commented Mar 2, 2016

(Giant?) Baby step towards using the new pipeline. This means removing any explicit calls to vtk_obj.output (where possible) and instead setting up pipeline connections. This still needs cleanup but seems to be the bare minimum changes needed for all the tests to pass. There are some places where the output is explicitly used to get information about the datasets but these could eventually be modified/refactored to use the vtkInformation classes.

prabhuramachandran added some commits Feb 27, 2016

Fix components to use newer pipeline.
Many of them were setting their outputs to the older vtk pipeline's
output.
Fix many of the Mayavi objects.
Most of them use the new pipeline now and the connections should be set
correctly for many of the objects.  All the tests pass with these
changes.  There is also a new convenient method called
`get_output_dataset` that can be used when one needs the output.  This
should be cleaned up later.
@kitchoi

This comment has been minimized.

Show comment
Hide comment
@kitchoi

kitchoi Mar 7, 2016

Member

May I ask which VTK version is this for?

Member

kitchoi commented Mar 7, 2016

May I ask which VTK version is this for?

@dmsurti

This comment has been minimized.

Show comment
Hide comment
@dmsurti

dmsurti Mar 7, 2016

Contributor

This is for VTK versions 6.x and later.

Contributor

dmsurti commented Mar 7, 2016

This is for VTK versions 6.x and later.

@dmsurti

This comment has been minimized.

Show comment
Hide comment
@dmsurti

dmsurti Mar 9, 2016

Contributor

Except issue #312, LGTM. Merging.

Contributor

dmsurti commented Mar 9, 2016

Except issue #312, LGTM. Merging.

dmsurti added a commit that referenced this pull request Mar 9, 2016

Merge pull request #309 from prabhuramachandran/fix-pipeline
Use newer pipeline where possible

@dmsurti dmsurti merged commit a556e1b into enthought:master Mar 9, 2016

3 checks passed

codecov/project 43.96% (target 40.00%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@prabhuramachandran prabhuramachandran deleted the prabhuramachandran:fix-pipeline branch Jul 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment