Fix Camera off-centered when loading saved visualization #310

Merged
merged 3 commits into from Mar 9, 2016

Conversation

Projects
None yet
3 participants
@kitchoi
Member

kitchoi commented Mar 4, 2016

Fix #283
After reading the vtkCamera.cxx code (especially the PartialCopy function here https://github.com/Kitware/VTK/blob/v6.3.0/Rendering/Core/vtkCamera.cxx#L1242) I am convinced that distance should be omitted upon restoration.

@kitchoi

This comment has been minimized.

Show comment
Hide comment
@kitchoi

kitchoi Mar 8, 2016

Member

@dmsurti Can you take a look please? Thanks.

Member

kitchoi commented Mar 8, 2016

@dmsurti Can you take a look please? Thanks.

@prabhuramachandran

This comment has been minimized.

Show comment
Hide comment
@prabhuramachandran

prabhuramachandran Mar 9, 2016

Member

LGTM! Merging.

Member

prabhuramachandran commented Mar 9, 2016

LGTM! Merging.

prabhuramachandran added a commit that referenced this pull request Mar 9, 2016

@prabhuramachandran prabhuramachandran merged commit eca9e24 into master Mar 9, 2016

5 checks passed

codecov/project 43.93% (target 40.00%)
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@prabhuramachandran prabhuramachandran deleted the fix-issue-283 branch Mar 9, 2016

@kitchoi kitchoi changed the title from Fix issue 283 to Fix Camera off-centered when loading saved visualization Jun 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment