Replacing links to code. and svn.enthought.com #313

Merged
merged 6 commits into from Mar 17, 2016

Conversation

Projects
None yet
3 participants
@kitchoi
Member

kitchoi commented Mar 10, 2016

Hunt down links to the code.enthought.com and svn.enthought.com domain.

Some of which are in scripts' docstrings that are invisible on the actual documentation website.

And I don't know what to do with these:

./docs/source/mayavi/installation.rst:.. _ETS: http://code.enthought.com/
./docs/source/mayavi/overview.rst:.. _ETS: http://code.enthought.com/projects/tool-suite.php
./examples/mayavi/mlab/chemistry.py:    'http://code.enthought.com/projects/mayavi/data/h2o-elf.cube'
./docs/source/mayavi/auto/chemistry.py:   'http://code.enthought.com/projects/mayavi/data/h2o-elf.cube'

Also don't know what to do with these:

./docs/API.txt:   https://svn.enthought.com/enthought/wiki/EnthoughtVersionNumbers
./mayavi/scripts/mayavi2.py:Mayavi2 wiki page: http://svn.enthought.com/enthought/wiki/MayaVi

I can't guarantee that I have done all of them, but this is a step forward.

@jdmarch can you take a look please?

@corranwebster

This comment has been minimized.

Show comment
Hide comment
@corranwebster

corranwebster Mar 10, 2016

Member

The link ./docs/API.txt: https://svn.enthought.com/enthought/wiki/EnthoughtVersionNumbers should point to the github repo (possibly to the releases sub-page https://github.com/enthought/mayavi/releases).

The link ./mayavi/scripts/mayavi2.py:Mayavi2 wiki page: http://svn.enthought.com/enthought/wiki/MayaVi should point to the Mayavi documentation http://docs.enthought.com/mayavi/mayavi/

Member

corranwebster commented Mar 10, 2016

The link ./docs/API.txt: https://svn.enthought.com/enthought/wiki/EnthoughtVersionNumbers should point to the github repo (possibly to the releases sub-page https://github.com/enthought/mayavi/releases).

The link ./mayavi/scripts/mayavi2.py:Mayavi2 wiki page: http://svn.enthought.com/enthought/wiki/MayaVi should point to the Mayavi documentation http://docs.enthought.com/mayavi/mayavi/

@kitchoi

This comment has been minimized.

Show comment
Hide comment
@kitchoi

kitchoi Mar 10, 2016

Member

Thanks @corranwebster! just updated those links

Member

kitchoi commented Mar 10, 2016

Thanks @corranwebster! just updated those links

@corranwebster

This comment has been minimized.

Show comment
Hide comment
@corranwebster

corranwebster Mar 10, 2016

Member

Having a look, I think that the other ones have to wait until we know what we are going to do with code.enthought.com. The datasets that are stored there could be moved into the github repo and the download links updated to grab the appropriate url; or we could add them to the documentation and download them from docs.enthought.com, but either way we have to keep the datasets at code.enthought.com for a while because people will still have old versions of Mayavi around for a while.

Member

corranwebster commented Mar 10, 2016

Having a look, I think that the other ones have to wait until we know what we are going to do with code.enthought.com. The datasets that are stored there could be moved into the github repo and the download links updated to grab the appropriate url; or we could add them to the documentation and download them from docs.enthought.com, but either way we have to keep the datasets at code.enthought.com for a while because people will still have old versions of Mayavi around for a while.

README-tvtk.txt
-the "register" link at the top right on the above page to register. Or login
-if you already have registered. Once you are registered you may file a bug by
-creating a new ticket.
+ https://github.com/enthought/mayavi

This comment has been minimized.

docs/source/mayavi/data.rst
@@ -518,7 +518,7 @@ objects or data files for Mayavi and TVTK.
* Presentation on TVTK and Mayavi2 for course at IIT Bombay
- https://svn.enthought.com/enthought/attachment/wiki/MayaVi/tvtk_mayavi2.pdf
+ In source: ./docs/pdf/tvtk_mayavi2.pdf

This comment has been minimized.

@@ -14,9 +14,11 @@
are modified to propagate them to the filter. For more information
on creating GUIs with Traits:
- http://code.enthought.com/projects/traits/docs/html/tutorials/traits_ui_scientific_app.html
+ http://docs.enthought.com/traitsui

This comment has been minimized.

@corranwebster

corranwebster Mar 10, 2016

Member

This tutorial is now part of the TraitsUI documentation: http://docs.enthought.com/traitsui/tutorials/traits_ui_scientific_app.html

This comment has been minimized.

@corranwebster

corranwebster Mar 10, 2016

Member

But it's worthwhile having a link to the main TraitsUI page as well.

@corranwebster

corranwebster Mar 10, 2016

Member

But it's worthwhile having a link to the main TraitsUI page as well.

@corranwebster

This comment has been minimized.

Show comment
Hide comment
@corranwebster

corranwebster Mar 10, 2016

Member

Other than the above notes, looks good to me.

Member

corranwebster commented Mar 10, 2016

Other than the above notes, looks good to me.

@kitchoi

This comment has been minimized.

Show comment
Hide comment
@kitchoi

kitchoi Mar 10, 2016

Member

Thanks @corranwebster! I have made the changes

Member

kitchoi commented Mar 10, 2016

Thanks @corranwebster! I have made the changes

@kitchoi kitchoi referenced this pull request Mar 14, 2016

Closed

Fix download URL #307

@prabhuramachandran

This comment has been minimized.

Show comment
Hide comment
@prabhuramachandran

prabhuramachandran Mar 17, 2016

Member

@kitchoi -- this is fantastic, thank you so much!

Member

prabhuramachandran commented Mar 17, 2016

@kitchoi -- this is fantastic, thank you so much!

prabhuramachandran added a commit that referenced this pull request Mar 17, 2016

Merge pull request #313 from enthought/clean-up-code-ent-links
Replacing links to code. and svn.enthought.com

@prabhuramachandran prabhuramachandran merged commit 1927066 into master Mar 17, 2016

3 of 5 checks passed

codecov/project CI failed: coverage not measured fully.
Details
continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@prabhuramachandran prabhuramachandran deleted the clean-up-code-ent-links branch Mar 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment