Suppresses test for VTK 6.2 (solves appVeyor random failure) #329

Merged
merged 3 commits into from Apr 1, 2016

Conversation

Projects
None yet
3 participants
@stefanoborini
Contributor

stefanoborini commented Mar 30, 2016

We have occasional appveyor failure which is probably due to the PLY format
still not working.

Suppresses test for VTK 6.2 (solves appVeyor random failure)
We have occasional appveyor failure which is probably due to the PLY format
still not working.
@stefanoborini

This comment has been minimized.

Show comment
Hide comment
@stefanoborini

stefanoborini Mar 30, 2016

Contributor

This should also solve current failing PRs. Please merge this one first, and will be brought into these PRs.

Contributor

stefanoborini commented Mar 30, 2016

This should also solve current failing PRs. Please merge this one first, and will be brought into these PRs.

@kitchoi

This comment has been minimized.

Show comment
Hide comment
@kitchoi

kitchoi Mar 31, 2016

Member

Perhaps add an issue number to the skip message?

Member

kitchoi commented Mar 31, 2016

Perhaps add an issue number to the skip message?

stefanoborini added some commits Apr 1, 2016

@stefanoborini

This comment has been minimized.

Show comment
Hide comment
@stefanoborini

stefanoborini Apr 1, 2016

Contributor

@kitchoi done. Merge?

Contributor

stefanoborini commented Apr 1, 2016

@kitchoi done. Merge?

@kitchoi

This comment has been minimized.

Show comment
Hide comment
@kitchoi

kitchoi Apr 1, 2016

Member

I don't think I know enough about the test case (its objective, why it only fails on VTK 5.6/5.8 and Windows) to say. @dmsurti, @prabhuramachandran?

Member

kitchoi commented Apr 1, 2016

I don't think I know enough about the test case (its objective, why it only fails on VTK 5.6/5.8 and Windows) to say. @dmsurti, @prabhuramachandran?

@prabhuramachandran

This comment has been minimized.

Show comment
Hide comment
@prabhuramachandran

prabhuramachandran Apr 1, 2016

Member

Fixing this will require some careful investigation. I guess this is fine for now as this particular error is getting to be irritating.

Member

prabhuramachandran commented Apr 1, 2016

Fixing this will require some careful investigation. I guess this is fine for now as this particular error is getting to be irritating.

@prabhuramachandran prabhuramachandran merged commit 0380acd into master Apr 1, 2016

5 checks passed

codecov/project 45.37% (target 40.00%)
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@prabhuramachandran prabhuramachandran deleted the feature/fix-for-appveyor-failure-0330-1653 branch Apr 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment