Revert "Fix savefig size and black image" #349

Merged
merged 1 commit into from Apr 21, 2016

Conversation

Projects
None yet
2 participants
@kitchoi
Member

kitchoi commented Apr 21, 2016

Reverts enthought/mayavi#331
This should not be merged yet.

@stefanoborini

This comment has been minimized.

Show comment
Hide comment
@stefanoborini

stefanoborini Apr 21, 2016

Contributor

oh ok... sorry, but does it work?

Contributor

stefanoborini commented Apr 21, 2016

oh ok... sorry, but does it work?

@kitchoi

This comment has been minimized.

Show comment
Hide comment
@kitchoi

kitchoi Apr 21, 2016

Member

Works except when on-screen + the size of image requested is larger than my physical screen resolution. It wasn't captured in the test_mlab_savefig.py as the image size was not big enough, and was only recently discovered (today)

Member

kitchoi commented Apr 21, 2016

Works except when on-screen + the size of image requested is larger than my physical screen resolution. It wasn't captured in the test_mlab_savefig.py as the image size was not big enough, and was only recently discovered (today)

@stefanoborini

This comment has been minimized.

Show comment
Hide comment
@stefanoborini

stefanoborini Apr 21, 2016

Contributor

Ok. Merging when green, please restore the branch and PR for the other one. Leave it [WIP]

Contributor

stefanoborini commented Apr 21, 2016

Ok. Merging when green, please restore the branch and PR for the other one. Leave it [WIP]

@kitchoi

This comment has been minimized.

Show comment
Hide comment
@kitchoi

kitchoi Apr 21, 2016

Member

Appveyor has hung but Travis passed. I will proceed with the revert now (sooner the better).

Member

kitchoi commented Apr 21, 2016

Appveyor has hung but Travis passed. I will proceed with the revert now (sooner the better).

@kitchoi kitchoi merged commit 35c13ec into master Apr 21, 2016

2 of 5 checks passed

codecov/project Waiting for CI to finish...
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@stefanoborini stefanoborini deleted the revert-331-fix-savefig-size-black-image branch Apr 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment