Reimplement fix savefig size and black image - step 2 (last) #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitchoi
changed the title
kitchoi
changed the title
but it does not seem to matter on my Linux local machine
…fer seems sketchy
|
Recent commits differentiate this PR from #331 |
kitchoi
changed the title
kitchoi
changed the title
|
With this fix, upon saving an image with a specific size while the window is on-screen (i.e. not offscreen), a new window is opened and then closed. This is not ideal and I would very much appreciate any suggestion for an alternative. Note that the problem this PR is trying to fix affects Linux+wx and Mac OS (qt4/wx). |
|
Stale, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#346, #347 and this complete the whole journey to #331
(I would leave #331 close and this one opens)
If this whole thing should be merged, this PR merges to the branch of #347, and then #347 will merge to the branch of #346.