ENH: Nice load pylab_luts.pkl #352

Merged
merged 3 commits into from Apr 24, 2016

Conversation

Projects
None yet
2 participants
@kitchoi
Member

kitchoi commented Apr 22, 2016

Supersede #342 as a new binary file is not required.

The original problem arises when git checkout the repository on Windows, *.pkl files are not thought as binary file and its line endings are converted. Adding .gitattributes solves the problem. On the other hand, I still think soft loading the pickle file is appropriate, for unforseen failures.

@kitchoi kitchoi changed the title from Nice load pylab_luts.pkl to ENH: Nice load pylab_luts.pkl Apr 22, 2016

@prabhuramachandran

This comment has been minimized.

Show comment
Hide comment
@prabhuramachandran

prabhuramachandran Apr 24, 2016

Member

LGTM thanks!

Member

prabhuramachandran commented Apr 24, 2016

LGTM thanks!

@prabhuramachandran prabhuramachandran merged commit 661b509 into master Apr 24, 2016

5 checks passed

codecov/project 45.49% (target 40.00%)
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@prabhuramachandran prabhuramachandran deleted the try-load-pylab-luts-warn branch Apr 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment