Removes array_ext.so/pyd on clean #358

Merged
merged 4 commits into from Apr 27, 2016

Conversation

Projects
None yet
4 participants
@stefanoborini
Contributor

stefanoborini commented Apr 26, 2016

Removes the extension as from issue #336.

stefanoborini added some commits Apr 26, 2016

Removes array_ext.so/pyd on clean
Removes the extension as from issue #336.
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Apr 26, 2016

Current coverage is 45.41%

Merging #358 into master will not change coverage

@@             master       #358   diff @@
==========================================
  Files           254        254          
  Lines         22891      22891          
  Methods           0          0          
  Messages          0          0          
  Branches       3028       3028          
==========================================
  Hits          10395      10395          
  Misses        11762      11762          
  Partials        734        734          

Sunburst

Powered by Codecov. Last updated by 303f76b

codecov-io commented Apr 26, 2016

Current coverage is 45.41%

Merging #358 into master will not change coverage

@@             master       #358   diff @@
==========================================
  Files           254        254          
  Lines         22891      22891          
  Methods           0          0          
  Messages          0          0          
  Branches       3028       3028          
==========================================
  Hits          10395      10395          
  Misses        11762      11762          
  Partials        734        734          

Sunburst

Powered by Codecov. Last updated by 303f76b

setup.py
+class MyClean(clean.clean):
+ def run(self):
+ print("Cleaning extensions")
+ clear_array_ext()

This comment has been minimized.

@rkern

rkern Apr 26, 2016

Member

Just implement it all in here. Your docstring and print message should note that it is deleting extensions that were built in-place in addition to the normal compile products that are cleaned.

@rkern

rkern Apr 26, 2016

Member

Just implement it all in here. Your docstring and print message should note that it is deleting extensions that were built in-place in addition to the normal compile products that are cleaned.

stefanoborini added some commits Apr 26, 2016

@prabhuramachandran prabhuramachandran merged commit f24319e into master Apr 27, 2016

7 checks passed

codecov/changes No unexpected coverage changes found.
Details
codecov/patch 100% of diff hit (target 45.41%)
Details
codecov/project 45.41% (+54.59%) compared to 51d7e13
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@prabhuramachandran prabhuramachandran deleted the feature/336-remove-array-ext-on-clean-0426-1148 branch Apr 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment