Debug info on code gen #405

Merged
merged 4 commits into from Jul 6, 2016

Conversation

Projects
None yet
3 participants
@itziakos
Member

itziakos commented Jun 23, 2016

Add basic debug support for the code_gen script

Details:

  • Add a logger and log debug info while wrapping vtk classes
  • Add -v, --verbose option on the code_gen script
  • Minor cleanup
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jun 23, 2016

Current coverage is 45.39%

Merging #405 into master will decrease coverage by 0.01%

@@             master       #405   diff @@
==========================================
  Files           254        254          
  Lines         22987      22999    +12   
  Methods           0          0          
  Messages          0          0          
  Branches       3033       3034     +1   
==========================================
+ Hits          10439      10441     +2   
- Misses        11832      11842    +10   
  Partials        716        716          

Powered by Codecov. Last updated by f103b39...12a384b

Current coverage is 45.39%

Merging #405 into master will decrease coverage by 0.01%

@@             master       #405   diff @@
==========================================
  Files           254        254          
  Lines         22987      22999    +12   
  Methods           0          0          
  Messages          0          0          
  Branches       3033       3034     +1   
==========================================
+ Hits          10439      10441     +2   
- Misses        11832      11842    +10   
  Partials        716        716          

Powered by Codecov. Last updated by f103b39...12a384b

+import logging
+
+# use a null handler when used as a library
+logging.getLogger('tvtk').addHandler(logging.NullHandler())

This comment has been minimized.

@prabhuramachandran

prabhuramachandran Jun 23, 2016

Member

Could you please explain why this is needed?

@prabhuramachandran

prabhuramachandran Jun 23, 2016

Member

Could you please explain why this is needed?

This comment has been minimized.

@itziakos

itziakos Jun 24, 2016

Member

Adding a null handler is suggested for libraries that use the python logging framework so that there is always a handler (see https://docs.python.org/2/howto/logging.html#configuring-logging-for-a-library).

@itziakos

itziakos Jun 24, 2016

Member

Adding a null handler is suggested for libraries that use the python logging framework so that there is always a handler (see https://docs.python.org/2/howto/logging.html#configuring-logging-for-a-library).

This comment has been minimized.

@prabhuramachandran

prabhuramachandran Jul 3, 2016

Member

Thanks, do you think this link could be put in a comment above this? Or is this obvious?

@prabhuramachandran

prabhuramachandran Jul 3, 2016

Member

Thanks, do you think this link could be put in a comment above this? Or is this obvious?

@prabhuramachandran prabhuramachandran merged commit 267f096 into master Jul 6, 2016

4 of 5 checks passed

codecov/project 45.39% (-0.02%) compared to f103b39
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@prabhuramachandran prabhuramachandran deleted the degub-info-on-code-gen branch Jul 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment