Fixes #403: Image plane widget and volume broken #406

Merged
merged 1 commit into from Jul 4, 2016

Conversation

Projects
None yet
3 participants
@prabhuramachandran
Member

prabhuramachandran commented Jun 26, 2016

These modules were using old-style tests which would fail with the new
pipeline related changes.

Fixes #403: Image plane widget and volume broken
These modules were using old-style tests which would fail with the new
pipeline related changes.
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jun 26, 2016

Current coverage is 45.81%

Merging #406 into master will increase coverage by 0.40%

@@             master       #406   diff @@
==========================================
  Files           254        254          
  Lines         22987      22988     +1   
  Methods           0          0          
  Messages          0          0          
  Branches       3033       3033          
==========================================
+ Hits          10439      10533    +94   
+ Misses        11832      11763    -69   
+ Partials        716        692    -24   

Powered by Codecov. Last updated by f103b39...df51fd4

Current coverage is 45.81%

Merging #406 into master will increase coverage by 0.40%

@@             master       #406   diff @@
==========================================
  Files           254        254          
  Lines         22987      22988     +1   
  Methods           0          0          
  Messages          0          0          
  Branches       3033       3033          
==========================================
+ Hits          10439      10533    +94   
+ Misses        11832      11763    -69   
+ Partials        716        692    -24   

Powered by Codecov. Last updated by f103b39...df51fd4

@prabhuramachandran

This comment has been minimized.

Show comment
Hide comment
@prabhuramachandran

prabhuramachandran Jul 3, 2016

Member

@kitchoi, @itziakos -- please review and merge. It LGTM of course so I am happy to self-merge if that is OK with you. :)

Member

prabhuramachandran commented Jul 3, 2016

@kitchoi, @itziakos -- please review and merge. It LGTM of course so I am happy to self-merge if that is OK with you. :)

@kitchoi

This comment has been minimized.

Show comment
Hide comment
@kitchoi

kitchoi Jul 4, 2016

Member

LGTM

Member

kitchoi commented Jul 4, 2016

LGTM

@prabhuramachandran

This comment has been minimized.

Show comment
Hide comment
@prabhuramachandran

prabhuramachandran Jul 4, 2016

Member

Thanks @kitchoi, merging!

Member

prabhuramachandran commented Jul 4, 2016

Thanks @kitchoi, merging!

@prabhuramachandran prabhuramachandran merged commit 68787e3 into enthought:master Jul 4, 2016

3 checks passed

codecov/project 45.81% (+0.40%) compared to f103b39
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@prabhuramachandran prabhuramachandran deleted the prabhuramachandran:fix-ipw-volume branch Jul 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment