Add additional save options #408

Merged
merged 3 commits into from Jul 3, 2016

Conversation

Projects
None yet
3 participants
@rpep
Contributor

rpep commented Jul 3, 2016

Hi @prabhuramachandran, I've removed the whitespace changes and created a new pull request.

R

@prabhuramachandran

This comment has been minimized.

Show comment
Hide comment
@prabhuramachandran

prabhuramachandran Jul 3, 2016

Member

Thanks @ryanpepper. Not sure why the builds are failing. @itziakos, any ideas? I would like to merge this.

Member

prabhuramachandran commented Jul 3, 2016

Thanks @ryanpepper. Not sure why the builds are failing. @itziakos, any ideas? I would like to merge this.

@rpep

This comment has been minimized.

Show comment
Hide comment
@rpep

rpep Jul 3, 2016

Contributor

Stupid mistake on my end :)

Contributor

rpep commented Jul 3, 2016

Stupid mistake on my end :)

tvtk/plugins/scene/ui/actions.py
+ wildcard = ''
+
+ for description, extension in zip(descriptions, extensions):
+ wildcard += '{} ({})|{}|".format(description, extension, extension)

This comment has been minimized.

@prabhuramachandran

prabhuramachandran Jul 3, 2016

Member

Another mistake here!

@prabhuramachandran

prabhuramachandran Jul 3, 2016

Member

Another mistake here!

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jul 3, 2016

Current coverage is 45.76%

Merging #408 into master will increase coverage by 0.35%

@@             master       #408   diff @@
==========================================
  Files           254        254          
  Lines         22987      23029    +42   
  Methods           0          0          
  Messages          0          0          
  Branches       3033       3039     +6   
==========================================
+ Hits          10439      10540   +101   
+ Misses        11832      11796    -36   
+ Partials        716        693    -23   

Powered by Codecov. Last updated by f103b39...e46a13a

codecov-io commented Jul 3, 2016

Current coverage is 45.76%

Merging #408 into master will increase coverage by 0.35%

@@             master       #408   diff @@
==========================================
  Files           254        254          
  Lines         22987      23029    +42   
  Methods           0          0          
  Messages          0          0          
  Branches       3033       3039     +6   
==========================================
+ Hits          10439      10540   +101   
+ Misses        11832      11796    -36   
+ Partials        716        693    -23   

Powered by Codecov. Last updated by f103b39...e46a13a

@prabhuramachandran

This comment has been minimized.

Show comment
Hide comment
@prabhuramachandran

prabhuramachandran Jul 3, 2016

Member

Thanks! LGTM, merging.

Member

prabhuramachandran commented Jul 3, 2016

Thanks! LGTM, merging.

@prabhuramachandran prabhuramachandran merged commit 6fa0f8f into enthought:master Jul 3, 2016

3 checks passed

codecov/project 45.76% (+0.35%) compared to f103b39
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment