Updated LUTs to include new matplotlib colorschemes #410

Merged
merged 2 commits into from Jul 7, 2016

Conversation

Projects
None yet
3 participants
@daytonb
Contributor

daytonb commented Jul 5, 2016

I had to modify the cm2lut.py script to get the cmaps which are not in
matplotlib.cm.datad. I don't understand why some of the cmaps are there
and others are in matplotlib._cm_listed.cmaps, but I figured out from
matplotlib.cm.get_cmap that they are.

Before this can really be committed, the gifs also need uploaded, but for me mlab.savefig() is just saving black png images. So I either need some direction on fixing that, or I need someone else to take my patch and upload the gifs.

All I've been able to find on the savefig bug is that I should use savefig before mlab.show() (which gen_lut_previews.py does not use) or that it's a vtk issue.

Updated LUTs to include new matplotlib colorschemes
I had to modify the cm2lut.py script to get the cmaps which are not in
matplotlib.cm.datad. I don't understand why some of the cmaps are there
and others are in matplotlib._cm_listed.cmaps, but I figured out from
matplotlib.cm.get_cmap that they are.
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jul 5, 2016

Current coverage is 45.38%

Merging #410 into master will decrease coverage by 0.39%

@@             master       #410   diff @@
==========================================
  Files           254        254          
  Lines         23030      23030          
  Methods           0          0          
  Messages          0          0          
  Branches       3039       3039          
==========================================
- Hits          10543      10452    -91   
- Misses        11795      11863    +68   
- Partials        692        715    +23   

Powered by Codecov. Last updated by 68787e3...4b31e0a

codecov-io commented Jul 5, 2016

Current coverage is 45.38%

Merging #410 into master will decrease coverage by 0.39%

@@             master       #410   diff @@
==========================================
  Files           254        254          
  Lines         23030      23030          
  Methods           0          0          
  Messages          0          0          
  Branches       3039       3039          
==========================================
- Hits          10543      10452    -91   
- Misses        11795      11863    +68   
- Partials        692        715    +23   

Powered by Codecov. Last updated by 68787e3...4b31e0a

@prabhuramachandran

This comment has been minimized.

Show comment
Hide comment
@prabhuramachandran

prabhuramachandran Jul 6, 2016

Member

LGTM, thanks! @GaelVaroquaux -- care to comment since this is mostly your code?

Member

prabhuramachandran commented Jul 6, 2016

LGTM, thanks! @GaelVaroquaux -- care to comment since this is mostly your code?

@prabhuramachandran

This comment has been minimized.

Show comment
Hide comment
@prabhuramachandran

prabhuramachandran Jul 7, 2016

Member

Seems to work well for me.

Member

prabhuramachandran commented Jul 7, 2016

Seems to work well for me.

@prabhuramachandran

This comment has been minimized.

Show comment
Hide comment
@prabhuramachandran

prabhuramachandran Jul 7, 2016

Member

Merging for now, @GaelVaroquaux -- if there are issues they could be addressed later.

Member

prabhuramachandran commented Jul 7, 2016

Merging for now, @GaelVaroquaux -- if there are issues they could be addressed later.

@prabhuramachandran prabhuramachandran merged commit 902af63 into enthought:master Jul 7, 2016

3 checks passed

codecov/project Absolute coverage decreased by -0.39% but relative coverage increased by +54.22% compared to 68787e3
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@prabhuramachandran

This comment has been minimized.

Show comment
Hide comment
Member

prabhuramachandran commented Jul 7, 2016

Thanks @daytonb!

@daytonb daytonb deleted the daytonb:viridis-lut branch Feb 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment