-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepared a more meaningful example of tvtk usage in Mayavi #974
Conversation
Codecov Report
@@ Coverage Diff @@
## master #974 +/- ##
=======================================
Coverage 49.83% 49.83%
=======================================
Files 263 263
Lines 23927 23927
Branches 3259 3259
=======================================
Hits 11924 11924
Misses 11220 11220
Partials 783 783 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks good, please make the minor change I suggest and I will merge this.
@marekyggdrasil -- please also rebase to current master. Thank you. |
@prabhuramachandran thanks for reviewing! I wrapped the lines to match the requested linting style and also merged the most recent master. No conflicts! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Hi all!
I have been struggling with
tvtk
usage in Mayavi, detail on why are provided in this question (which is answered now).I figured a more meaningful example could be useful. The previous scene was:
And now it is:
I believe it is better because:
If you need some more adjustments let me know and if you are not interested in it just close the PR. Thanks!