Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

REFACTOR: Renamed new AdvancedEditorAreaPane to SplitEditorAreaPane. #65

Merged
merged 1 commit into from Nov 1, 2012

Conversation

Projects
None yet
4 participants
Contributor

agrawalprash commented Oct 31, 2012

The previous implementation is available under the name AdvancedEditorAreaPane.

REFACTOR: Renamed new AdvancedEditorAreaPane to SplitEditorAreaPane.
The previous implementation is available under the name AdvancedEditorAreaPane.
Member

prabhuramachandran commented Oct 31, 2012

Thanks for doing this!

Member

prabhuramachandran commented Nov 1, 2012

@rkern, @pberkes, @itziakos -- Please merge this as you see fit. I will not be merging it since I do not know what works best for you.

Member

itziakos commented Nov 1, 2012

It looks ok to me.

Thanks for doing this.

itziakos added a commit that referenced this pull request Nov 1, 2012

Merge pull request #65 from agrawalprash/rename-aeap
REFACTOR: Renamed new AdvancedEditorAreaPane to SplitEditorAreaPane.

@itziakos itziakos merged commit 28e8de3 into enthought:master Nov 1, 2012

Contributor

pberkes commented Nov 14, 2012

Please clean up the test_advanced_area_pane.py tests as well:

  1. fix the tests
  2. move to tests/
  3. remove the tab characters
    Thanks!
Contributor

pberkes commented Nov 15, 2012

@agrawalprash The example in examples/advanced is also broken (in addition to the tests, see previous comments). Could you please fix that in a new pull request?

Contributor

agrawalprash commented Nov 15, 2012

Yes, I will clean up all of this by tonight.

On Thu, Nov 15, 2012 at 2:18 PM, Pietro Berkes notifications@github.comwrote:

@agrawalprash https://github.com/agrawalprash The example in
examples/advanced is also broken (in addition to the tests, see previous
comments). Could you please fix that in a new pull request?


Reply to this email directly or view it on GitHubhttps://github.com/enthought/pyface/pull/65#issuecomment-10401151.

Prashant Agrawal
Software Developer
Enthought India

Contributor

pberkes commented Nov 15, 2012

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment