Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix destruction of tasks actions #66

Merged
merged 3 commits into from Nov 14, 2012

Conversation

Projects
None yet
3 participants
Contributor

pberkes commented Nov 14, 2012

A few tasks-related actions did not properly dispose of listeners to other object when they were destroyed.

pberkes added some commits Nov 14, 2012

@pberkes pberkes FIX: properly destroy tasks actions
A few tasks-related actions did not properly dispose
of listeners to other object when they were destroyed.
d2328f0
@pberkes pberkes Doc correction. 1946227
Member

rkern commented Nov 14, 2012

LGTM

@itziakos itziakos and 1 other commented on an outdated diff Nov 14, 2012

pyface/tasks/action/task_toggle_group.py
@@ -35,6 +42,8 @@ def perform(self, event=None):
###########################################################################
def _get_name(self):
+ if self.task is None:
+ return 'DELETED TASK TOGGLE'
@itziakos

itziakos Nov 14, 2012

Member

I think that here it should return Undefined

@pberkes

pberkes Nov 14, 2012

Contributor

Good point, but name is a Unicode trait, and Undefined is not unicode...

@pberkes pberkes Default name of toggle group actions is 'UNDEFINED'.
Set name toggle group actions to 'UNDEFINED' when the
corresponding object (task or dock pane) is None. This
is slightly better than 'DELETED' as there might be other
reasons why the object is None.
da07be8

@itziakos itziakos added a commit that referenced this pull request Nov 14, 2012

@itziakos itziakos Merge pull request #66 from enthought/fix-tasks-actions
Fix destruction of tasks actions
a163e55

@itziakos itziakos merged commit a163e55 into master Nov 14, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment