Mergeable schemas #73

Merged
merged 4 commits into from Dec 27, 2012

3 participants

@pberkes

This PR extends the ActionManagerBuilder so that it merges schemas with the same path.

If a task defines a schema (e.g. a menu or a group schema) with a given path, and a SchemaAdditions adds a schema with the same path, the two are merged.

The merge only succeeds for schemas with the same type. For example, if one contributes a menu schema and a group schema with the same path (bad idea), both the menu and the group are created.

pberkes added some commits Dec 18, 2012
@pberkes pberkes Small cleanups. 886484f
@pberkes pberkes ActionManagerBuilder merges schemas with the same path.
This commit makes sure that if a task is defining a schema
(e.g. a menu or a group schema) with a given path, and a
SchemaAdditions adds a schema with the same path, the two are merged.

The merge only succeeds for schemas with the same type.
1d46a07
@pberkes pberkes Add unique ID to schemas by default.
This avoids that schemas are merged when a user forgets
to set the schema ID.
2daea8a
@pberkes pberkes Fix incomplete commit…
Sorry about that.
c061d8b
@rkern
Enthought, Inc. member

LGTM.

@nmichaud

Agreed, merging.

@nmichaud nmichaud merged commit 88cdcb6 into master Dec 27, 2012
@nmichaud nmichaud deleted the mergeable-schemas branch Dec 27, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment