Schema for Pyface Actions. #74

Merged
merged 5 commits into from Dec 27, 2012

Conversation

Projects
None yet
3 participants
@pberkes
Contributor

pberkes commented Dec 18, 2012

An action schema cannot have children. It is used as an action factory
to make sure a larger schema (e.g., a menu schema) can be used multiple
times. Without using an ActionSchema, a reference to the action is added
to every menu created from the schema. When one of the menus is destroyed,
the action is also destroyed and is made unusable.

pberkes added some commits Dec 18, 2012

Schema for Pyface Actions.
    An action schema cannot have children. It is used as an action factory
    to make sure a larger schema (e.g., a menu schema) can be used multiple
    times. Without using an ActionSchema, a reference to the copy is added
    to every menu created from the schema. When one of the menus is destroyed,
    the action is also destroyed and is made unusable.
Inject 'id' trait in Actions created by an ActionSchema.
This is to be consistent with what the other schemas do.
@rkern

This comment has been minimized.

Show comment Hide comment
@rkern

rkern Dec 27, 2012

Member

LGTM.

Member

rkern commented Dec 27, 2012

LGTM.

@nmichaud

This comment has been minimized.

Show comment Hide comment
@nmichaud

nmichaud Dec 27, 2012

Agreed, merging.

Agreed, merging.

nmichaud pushed a commit that referenced this pull request Dec 27, 2012

@nmichaud nmichaud merged commit 0173533 into master Dec 27, 2012

@nmichaud nmichaud deleted the action-schema branch Dec 27, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment