Skip to content

Conversation

@mdickinson
Copy link
Member

@mdickinson mdickinson commented Feb 4, 2020

We don't test the machinery in traits.testing.nose_tools, but there are other parts of ETS that still use it. Those users are likely no longer using nose to run their test suites.

EDIT: I'm only seeing uses of nose_tools in etsproxy, which we don't care about at this point. No other uses of nose_tools in ETS. Still, there might be external uses that we don't know about, so we can't simply delete without warning.

Related: #852.

@codecov-io
Copy link

codecov-io commented Feb 4, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@63b138f). Click here to learn what that means.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #880   +/-   ##
=========================================
  Coverage          ?   72.58%           
=========================================
  Files             ?       51           
  Lines             ?     6375           
  Branches          ?     1278           
=========================================
  Hits              ?     4627           
  Misses            ?     1355           
  Partials          ?      393
Impacted Files Coverage Δ
traits/testing/nose_tools.py 60.71% <71.42%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b138f...6681a85. Read the comment docs.

@mdickinson mdickinson merged commit a6411e9 into master Feb 4, 2020
@mdickinson mdickinson deleted the deprecate-nose-tools branch February 4, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants